Fix menu system crashes and stability issues

- Fix IrisSpotlight crash ($00F361): Removed errant $0116/$17 writes
  from menu_select_item.asm that corrupted VRAM upload index
- Fix journal stack corruption: Added missing PHB in Journal_CountUnlocked
- Fix P register mismatches: Added SEP #$30 to Menu_RefreshQuestScreen,
  Menu_ScrollFrom, Menu_DrawRingPrompt
- Fix MagicBag crashes: Fixed data bank corruption in error path,
  fixed uninitialized Y register in cursor movement
- Relocate StoryState from volatile $7C to SRAM $7EF39E
- Add bounds checking to HouseTag_Main jump table
- Use long addressing (.l) for SRAM access in custom_tag.asm

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
scawful
2025-11-22 03:20:35 -05:00
parent e485439628
commit 8b23049e28
7 changed files with 1129 additions and 894 deletions

View File

@@ -87,6 +87,12 @@ MagicBeanProg = $7EF39B
JournalState = $7EF39C
; State machine for Link's House intro sequence (custom_tag.asm)
; 0x00 - Telepathic Plea phase
; 0x01 - Wake Up Player phase
; 0x02 - End (intro complete)
StoryState = $7EF39E
; 7EF403 - 7EF4FD Unused block
; .... .cpw