scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make hex format strings const static

Browse Source
This commit is contained in:
Justin Scofield
2024-12-31 11:41:26 -05:00
parent 8becdbcbb0
commit 1ca1e5f17a
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/app/core/common.cc
View File

@@ -112,8 +112,8 @@ void HandleHexStringParams(const std::string &hex,
std::string HexByte(uint8_t byte, HexStringParams params) { std::string HexByte(uint8_t byte, HexStringParams params) {
std::string result; std::string result;
constexpr std::string kLowerFormat = "%02x"; const static std::string kLowerFormat = "%02x";
constexpr std::string kUpperFormat = "%02X"; const static std::string kUpperFormat = "%02X";
if (params.uppercase) { if (params.uppercase) {
result = absl::StrFormat(kUpperFormat.c_str(), byte); result = absl::StrFormat(kUpperFormat.c_str(), byte);
} else { } else {
@@ -125,8 +125,8 @@ std::string HexByte(uint8_t byte, HexStringParams params) {
std::string HexWord(uint16_t word, HexStringParams params) { std::string HexWord(uint16_t word, HexStringParams params) {
std::string result; std::string result;
constexpr std::string kLowerFormat = "%04x"; const static std::string kLowerFormat = "%04x";
constexpr std::string kUpperFormat = "%04X"; const static std::string kUpperFormat = "%04X";
if (params.uppercase) { if (params.uppercase) {
result = absl::StrFormat(kUpperFormat.c_str(), word); result = absl::StrFormat(kUpperFormat.c_str(), word);
} else { } else {
@@ -138,8 +138,8 @@ std::string HexWord(uint16_t word, HexStringParams params) {
std::string HexLong(uint32_t dword, HexStringParams params) { std::string HexLong(uint32_t dword, HexStringParams params) {
std::string result; std::string result;
constexpr std::string kLowerFormat = "%06x"; const static std::string kLowerFormat = "%06x";
constexpr std::string kUpperFormat = "%06X"; const static std::string kUpperFormat = "%06X";
if (params.uppercase) { if (params.uppercase) {
result = absl::StrFormat(kUpperFormat.c_str(), dword); result = absl::StrFormat(kUpperFormat.c_str(), dword);
} else { } else {
@@ -151,8 +151,8 @@ std::string HexLong(uint32_t dword, HexStringParams params) {
std::string HexLongLong(uint64_t qword, HexStringParams params) { std::string HexLongLong(uint64_t qword, HexStringParams params) {
std::string result; std::string result;
constexpr std::string kLowerFormat = "%08x"; const static std::string kLowerFormat = "%08x";
constexpr std::string kUpperFormat = "%08X"; const static std::string kUpperFormat = "%08X";
if (params.uppercase) { if (params.uppercase) {
result = absl::StrFormat(kUpperFormat.c_str(), qword); result = absl::StrFormat(kUpperFormat.c_str(), qword);
} else { } else {