From 262647d9e2f3a76a48b7015c83036debcc659ff1 Mon Sep 17 00:00:00 2001
From: scawful <justin.scofield@outlook.com>
Date: Sat, 1 Nov 2025 10:53:50 -0400
Subject: [PATCH] chore: add validation script for GitHub Actions composite
 actions

- Introduced a new script, `validate-actions.sh`, to validate the structure of GitHub Actions composite actions, ensuring required fields are present and correctly configured.
- The script checks for the existence of action files, required fields, and proper references in the CI workflow, enhancing the reliability of CI processes.

Benefits:
- Improves the integrity of GitHub Actions by automating validation checks, reducing the likelihood of misconfigurations.
- Streamlines the CI workflow by ensuring that all actions are correctly defined and referenced before execution.
---
 .github/scripts/validate-actions.sh | 84 +++++++++++++++++++++++++++++
 third_party/benchmark               |  1 -
 third_party/zlib                    |  1 -
 3 files changed, 84 insertions(+), 2 deletions(-)
 create mode 100755 .github/scripts/validate-actions.sh
 delete mode 160000 third_party/benchmark
 delete mode 160000 third_party/zlib

diff --git a/.github/scripts/validate-actions.sh b/.github/scripts/validate-actions.sh
new file mode 100755
index 00000000..1e200019
--- /dev/null
+++ b/.github/scripts/validate-actions.sh
@@ -0,0 +1,84 @@
+#!/bin/bash
+# Validate GitHub Actions composite action structure
+
+set -e
+
+echo "Validating GitHub Actions composite actions..."
+
+ACTIONS_DIR=".github/actions"
+REQUIRED_FIELDS=("name" "description" "runs")
+
+validate_action() {
+    local action_file="$1"
+    local action_name=$(basename $(dirname "$action_file"))
+    
+    echo "Checking $action_name..."
+    
+    # Check if file exists
+    if [ ! -f "$action_file" ]; then
+        echo "  ✗ action.yml not found"
+        return 1
+    fi
+    
+    # Check required fields
+    for field in "${REQUIRED_FIELDS[@]}"; do
+        if ! grep -q "^${field}:" "$action_file"; then
+            echo "  ✗ Missing required field: $field"
+            return 1
+        fi
+    done
+    
+    # Check for 'using: composite'
+    if ! grep -q "using: 'composite'" "$action_file"; then
+        echo "  ✗ Not marked as composite action"
+        return 1
+    fi
+    
+    echo "  ✓ Valid composite action"
+    return 0
+}
+
+# Validate all actions
+all_valid=true
+for action_yml in "$ACTIONS_DIR"/*/action.yml; do
+    if ! validate_action "$action_yml"; then
+        all_valid=false
+    fi
+done
+
+# Check that CI workflow references actions correctly
+echo ""
+echo "Checking CI workflow..."
+CI_FILE=".github/workflows/ci.yml"
+
+if [ ! -f "$CI_FILE" ]; then
+    echo "  ✗ CI workflow not found"
+    all_valid=false
+else
+    # Check for checkout before action usage
+    if grep -q "uses: actions/checkout@v4" "$CI_FILE"; then
+        echo "  ✓ Repository checkout step present"
+    else
+        echo "  ✗ Missing checkout step"
+        all_valid=false
+    fi
+    
+    # Check for composite action references
+    action_refs=$(grep -c "uses: ./.github/actions/" "$CI_FILE" || echo "0")
+    if [ "$action_refs" -gt 0 ]; then
+        echo "  ✓ Found $action_refs composite action references"
+    else
+        echo "  ✗ No composite action references found"
+        all_valid=false
+    fi
+fi
+
+echo ""
+if [ "$all_valid" = true ]; then
+    echo "✓ All validations passed!"
+    exit 0
+else
+    echo "✗ Some validations failed"
+    exit 1
+fi
+
diff --git a/third_party/benchmark b/third_party/benchmark
deleted file mode 160000
index 7b9e482e..00000000
--- a/third_party/benchmark
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 7b9e482e3dbbfaa96c0d334a30ab8c22b69ee868
diff --git a/third_party/zlib b/third_party/zlib
deleted file mode 160000
index 5a82f71e..00000000
--- a/third_party/zlib
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 5a82f71ed1dfc0bec044d9702463dbdf84ea3b71