refactor: Remove deprecated instruction logging feature

- Eliminated the kLogInstructions flag and associated logging functionality, as the DisassemblyViewer is now always active and utilizes a more efficient sparse address-map recording method.
- Updated relevant code across multiple files to reflect the removal of the deprecated feature, ensuring cleaner and more maintainable code.
- Adjusted UI elements and serialization methods to remove references to the obsolete logging feature, streamlining the user experience.
This commit is contained in:
scawful
2025-10-08 21:00:46 -04:00
parent 3125ff4b76
commit 268921f55e
8 changed files with 39 additions and 64 deletions

View File

@@ -13,9 +13,9 @@ namespace core {
class FeatureFlags {
public:
struct Flags {
// Log instructions to the GUI debugger.
// WARNING: Setting this to true causes SEVERE performance degradation
bool kLogInstructions = false;
// REMOVED: kLogInstructions - DisassemblyViewer is now always enabled
// It uses sparse address-map recording (Mesen-style) with zero performance impact
// Recording can be disabled per-viewer via UI if needed
// Flag to enable the saving of all palettes to the Rom.
bool kSaveAllPalettes = false;
@@ -83,8 +83,7 @@ class FeatureFlags {
std::string Serialize() const {
std::string result;
result +=
"kLogInstructions: " + std::to_string(get().kLogInstructions) + "\n";
// REMOVED: kLogInstructions (deprecated)
result +=
"kSaveAllPalettes: " + std::to_string(get().kSaveAllPalettes) + "\n";
result += "kSaveGfxGroups: " + std::to_string(get().kSaveGfxGroups) + "\n";