refactor: Remove deprecated instruction logging feature

- Eliminated the kLogInstructions flag and associated logging functionality, as the DisassemblyViewer is now always active and utilizes a more efficient sparse address-map recording method.
- Updated relevant code across multiple files to reflect the removal of the deprecated feature, ensuring cleaner and more maintainable code.
- Adjusted UI elements and serialization methods to remove references to the obsolete logging feature, streamlining the user experience.
This commit is contained in:
scawful
2025-10-08 21:00:46 -04:00
parent 3125ff4b76
commit 268921f55e
8 changed files with 39 additions and 64 deletions

View File

@@ -166,8 +166,8 @@ void Emulator::Run(Rom* rom) {
}
snes_.Init(rom_data_);
// Enable instruction logging for disassembly viewer
snes_.cpu().SetInstructionLogging(true);
// Note: DisassemblyViewer recording is always enabled via callback
// No explicit setup needed - callback is set in Initialize()
// Note: PPU pixel format set to 1 (XBGR) in Init() which matches ARGB8888 texture
@@ -615,7 +615,14 @@ void Emulator::RenderNavBar() {
ImGui::SetTooltip("About Debugger");
}
SameLine();
ImGui::Checkbox("Logging", snes_.cpu().mutable_log_instructions());
// Recording control moved to DisassemblyViewer UI
bool recording = disassembly_viewer_.IsRecording();
if (ImGui::Checkbox("Recording", &recording)) {
disassembly_viewer_.SetRecording(recording);
}
if (ImGui::IsItemHovered()) {
ImGui::SetTooltip("Toggle instruction recording to DisassemblyViewer\n(Always lightweight - uses sparse address map)");
}
SameLine();
ImGui::Checkbox("Turbo", &turbo_mode_);