Refactor common functionality into zelda3 namespace; remove references to core::common

src/app/core/common.cc

@@ -1,80 +0,0 @@
-#include "common.h"
-
-#include <cstdint>
-#include <cstring>
-#include <string>
-#include <vector>
-
-#include "absl/strings/str_cat.h"
-#include "absl/strings/str_format.h"
-
-namespace yaze {
-namespace core {
-
-namespace {
-
-// "load little endian value at the given byte offset and shift to get its
-// value relative to the base offset (powers of 256, essentially)"
-unsigned ldle(uint8_t const *const p_arr, unsigned const p_index) {
-  uint32_t v = p_arr[p_index];
-  v <<= (8 * p_index);
-  return v;
-}
-
-void stle(uint8_t *const p_arr, size_t const p_index, unsigned const p_val) {
-  uint8_t v = (p_val >> (8 * p_index)) & 0xff;
-  p_arr[p_index] = v;
-}
-
-void stle0(uint8_t *const p_arr, unsigned const p_val) {
-  stle(p_arr, 0, p_val);
-}
-
-void stle1(uint8_t *const p_arr, unsigned const p_val) {
-  stle(p_arr, 1, p_val);
-}
-
-void stle2(uint8_t *const p_arr, unsigned const p_val) {
-  stle(p_arr, 2, p_val);
-}
-
-void stle3(uint8_t *const p_arr, unsigned const p_val) {
-  stle(p_arr, 3, p_val);
-}
-
-// Helper function to get the first byte in a little endian number
-uint32_t ldle0(uint8_t const *const p_arr) { return ldle(p_arr, 0); }
-
-// Helper function to get the second byte in a little endian number
-uint32_t ldle1(uint8_t const *const p_arr) { return ldle(p_arr, 1); }
-
-// Helper function to get the third byte in a little endian number
-uint32_t ldle2(uint8_t const *const p_arr) { return ldle(p_arr, 2); }
-
-// Helper function to get the third byte in a little endian number
-uint32_t ldle3(uint8_t const *const p_arr) { return ldle(p_arr, 3); }
-
-}  // namespace
-
-void stle16b_i(uint8_t *const p_arr, size_t const p_index,
-               uint16_t const p_val) {
-  stle16b(p_arr + (p_index * 2), p_val);
-}
-
-void stle16b(uint8_t *const p_arr, uint16_t const p_val) {
-  stle0(p_arr, p_val);
-  stle1(p_arr, p_val);
-}
-
-uint16_t ldle16b(uint8_t const *const p_arr) {
-  uint16_t v = 0;
-  v |= (ldle0(p_arr) | ldle1(p_arr));
-  return v;
-}
-
-uint16_t ldle16b_i(uint8_t const *const p_arr, size_t const p_index) {
-  return ldle16b(p_arr + (2 * p_index));
-}
-
-}  // namespace core
-}  // namespace yaze

src/app/core/common.h

@@ -1,43 +0,0 @@
-#ifndef YAZE_CORE_COMMON_H
-#define YAZE_CORE_COMMON_H
-
-#include <chrono>
-#include <cstdint>
-#include <fstream>
-#include <iostream>
-#include <string>
-
-#include "absl/strings/str_cat.h"
-#include "absl/strings/str_format.h"
-
-namespace yaze {
-
-/**
- * @namespace yaze::core
- * @brief Core application logic and utilities.
- */
-namespace core {
-
-/**
- * @brief Store little endian 16-bit value using a byte pointer, offset by an
- * index before dereferencing
- */
-void stle16b_i(uint8_t *const p_arr, size_t const p_index,
-               uint16_t const p_val);
-
-void stle16b(uint8_t *const p_arr, uint16_t const p_val);
-
-/**
- * @brief Load little endian halfword (16-bit) dereferenced from an arrays of
- * bytes. This version provides an index that will be multiplied by 2 and added
- * to the base address.
- */
-uint16_t ldle16b_i(uint8_t const *const p_arr, size_t const p_index);
-
-// Load little endian halfword (16-bit) dereferenced from
-uint16_t ldle16b(uint8_t const *const p_arr);
-
-}  // namespace core
-}  // namespace yaze
-
-#endif

src/app/core/core.cmake

@@ -1,6 +1,5 @@
 set(
   YAZE_APP_CORE_SRC
-  app/core/common.cc
   app/core/controller.cc
   app/emu/emulator.cc
   app/core/project.cc

src/app/core/project.h

@@ -7,7 +7,6 @@
 #include <vector>
 
 #include "absl/status/status.h"
-#include "app/core/common.h"
 #include "app/core/platform/file_dialog.h"
 
 namespace yaze {