Update Spc700 tests, add IPL rom test

This commit is contained in:
scawful
2023-12-05 03:47:57 -05:00
parent 04ef6cb35b
commit 2c5a9f904d
2 changed files with 129 additions and 31 deletions

View File

@@ -912,7 +912,7 @@ TEST_F(CPUTest, BNE_BranchTaken) {
mock_memory.SetMemoryContents(data); mock_memory.SetMemoryContents(data);
cpu.ExecuteInstruction(0xD0); // BNE cpu.ExecuteInstruction(0xD0); // BNE
EXPECT_EQ(cpu.PC, 0x0005); EXPECT_EQ(cpu.PC, 0x0007);
} }
TEST_F(CPUTest, BNE_BranchNotTaken) { TEST_F(CPUTest, BNE_BranchNotTaken) {

View File

@@ -1,5 +1,6 @@
#include "app/emu/audio/spc700.h" #include "app/emu/audio/spc700.h"
#include <gmock/gmock-nice-strict.h>
#include <gmock/gmock.h> #include <gmock/gmock.h>
#include <gtest/gtest.h> #include <gtest/gtest.h>
@@ -8,6 +9,7 @@ namespace app {
namespace emu { namespace emu {
using testing::_; using testing::_;
using testing::Return;
class MockAudioRAM : public AudioRam { class MockAudioRAM : public AudioRam {
public: public:
@@ -15,20 +17,23 @@ class MockAudioRAM : public AudioRam {
MOCK_METHOD(void, write, (uint16_t address, uint8_t value), (override)); MOCK_METHOD(void, write, (uint16_t address, uint8_t value), (override));
}; };
class SPC700Test : public ::testing::Test { class Spc700Test : public ::testing::Test {
public: public:
SPC700Test() = default; Spc700Test() = default;
MockAudioRAM audioRAM; testing::NiceMock<MockAudioRAM> audioRAM;
SPC700 spc700{audioRAM}; Spc700 spc700{audioRAM};
}; };
TEST_F(SPC700Test, ExecuteMOVWithImmediate) { // ============================================================================
// 8-bit Move Memory to Register
TEST_F(Spc700Test, MOV_A_Immediate) {
// MOV A, imm // MOV A, imm
uint8_t opcode = 0xE8; uint8_t opcode = 0xE8;
uint8_t immediate_value = 0x5A; uint8_t immediate_value = 0x5A;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(immediate_value)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -37,13 +42,100 @@ TEST_F(SPC700Test, ExecuteMOVWithImmediate) {
EXPECT_EQ(spc700.PSW.N, 0); EXPECT_EQ(spc700.PSW.N, 0);
} }
TEST_F(SPC700Test, ExecuteADCWithImmediate) { TEST_F(Spc700Test, MOV_A_X) {
// MOV A, X
uint8_t opcode = 0x7D;
spc700.X = 0x5A;
spc700.ExecuteInstructions(opcode);
EXPECT_EQ(spc700.A, spc700.X);
EXPECT_EQ(spc700.PSW.Z, 0);
EXPECT_EQ(spc700.PSW.N, 0);
}
// ============================================================================
// 8-bit Move Register to Memory
TEST_F(Spc700Test, MOV_Immediate) {
// MOV A, imm
uint8_t opcode = 0xE8;
uint8_t immediate_value = 0x5A;
EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode);
EXPECT_EQ(spc700.A, immediate_value);
EXPECT_EQ(spc700.PSW.Z, 0);
EXPECT_EQ(spc700.PSW.N, 0);
}
// ============================================================================
TEST_F(Spc700Test, NOP_DoesNothing) {
// NOP opcode
uint8_t opcode = 0x00;
uint16_t initialPC = spc700.PC;
spc700.ExecuteInstructions(opcode);
// PC should increment by 1, no other changes
EXPECT_EQ(spc700.PC, initialPC + 1);
// Add checks for other registers if needed
}
TEST_F(Spc700Test, ADC_A_Immediate) {
// ADC A, #imm
uint8_t opcode = 0x88;
uint8_t immediate_value = 0x10;
spc700.A = 0x01;
spc700.PSW.C = 1; // Assume carry is set
EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode);
// Verify A, and flags
EXPECT_EQ(spc700.A, 0x12); // 0x01 + 0x10 + 1 (carry)
// Check for other flags (Z, C, etc.) based on the result
}
TEST_F(Spc700Test, BEQ_BranchesIfZeroFlagSet) {
// BEQ rel
uint8_t opcode = 0xF0;
int8_t offset = 0x05;
spc700.PSW.Z = 1; // Set Zero flag
EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(offset));
uint16_t initialPC = spc700.PC + 1;
spc700.ExecuteInstructions(opcode);
EXPECT_EQ(spc700.PC, initialPC + offset);
}
TEST_F(Spc700Test, STA_Absolute) {
// STA !abs
uint8_t opcode = 0x85;
uint16_t abs_addr = 0x1234;
spc700.A = 0x80;
// Set up the mock to return the address for the absolute addressing
EXPECT_CALL(audioRAM, read(_))
.WillOnce(Return(abs_addr & 0xFF)) // Low byte
.WillOnce(Return(abs_addr >> 8)); // High byte
spc700.ExecuteInstructions(opcode);
}
TEST_F(Spc700Test, ExecuteADCWithImmediate) {
// ADC A, imm // ADC A, imm
uint8_t opcode = 0x88; // Replace with opcode for ADC A, imm uint8_t opcode = 0x88; // Replace with opcode for ADC A, imm
uint8_t immediate_value = 0x10; uint8_t immediate_value = 0x10;
spc700.A = 0x15; spc700.A = 0x15;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(immediate_value)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -53,12 +145,12 @@ TEST_F(SPC700Test, ExecuteADCWithImmediate) {
EXPECT_EQ(spc700.PSW.C, 0); EXPECT_EQ(spc700.PSW.C, 0);
} }
TEST_F(SPC700Test, ExecuteBRA) { TEST_F(Spc700Test, ExecuteBRA) {
// BRA // BRA
uint8_t opcode = 0x2F; uint8_t opcode = 0x2F;
int8_t offset = 0x05; int8_t offset = 0x05;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(offset)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(offset));
// rel() moves the PC forward one after read // rel() moves the PC forward one after read
uint16_t initialPC = spc700.PC + 1; uint16_t initialPC = spc700.PC + 1;
@@ -67,18 +159,17 @@ TEST_F(SPC700Test, ExecuteBRA) {
EXPECT_EQ(spc700.PC, initialPC + offset); EXPECT_EQ(spc700.PC, initialPC + offset);
} }
TEST_F(SPC700Test, ReadFromAudioRAM) { TEST_F(Spc700Test, ReadFromAudioRAM) {
uint16_t address = 0x1234; uint16_t address = 0x1234;
uint8_t expected_value = 0x5A; uint8_t expected_value = 0x5A;
EXPECT_CALL(audioRAM, read(address)) EXPECT_CALL(audioRAM, read(address)).WillOnce(Return(expected_value));
.WillOnce(testing::Return(expected_value));
uint8_t value = spc700.read(address); uint8_t value = spc700.read(address);
EXPECT_EQ(value, expected_value); EXPECT_EQ(value, expected_value);
} }
TEST_F(SPC700Test, WriteToAudioRAM) { TEST_F(Spc700Test, WriteToAudioRAM) {
uint16_t address = 0x1234; uint16_t address = 0x1234;
uint8_t value = 0x5A; uint8_t value = 0x5A;
@@ -87,13 +178,13 @@ TEST_F(SPC700Test, WriteToAudioRAM) {
spc700.write(address, value); spc700.write(address, value);
} }
TEST_F(SPC700Test, ExecuteANDWithImmediate) { TEST_F(Spc700Test, ExecuteANDWithImmediate) {
// AND A, imm // AND A, imm
uint8_t opcode = 0x28; uint8_t opcode = 0x28;
uint8_t immediate_value = 0x0F; uint8_t immediate_value = 0x0F;
spc700.A = 0x5A; // 0101 1010 spc700.A = 0x5A; // 0101 1010
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(immediate_value)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -102,13 +193,13 @@ TEST_F(SPC700Test, ExecuteANDWithImmediate) {
EXPECT_EQ(spc700.PSW.N, 0); EXPECT_EQ(spc700.PSW.N, 0);
} }
TEST_F(SPC700Test, ExecuteORWithImmediate) { TEST_F(Spc700Test, ExecuteORWithImmediate) {
// OR A, imm // OR A, imm
uint8_t opcode = 0x08; uint8_t opcode = 0x08;
uint8_t immediate_value = 0x0F; uint8_t immediate_value = 0x0F;
spc700.A = 0xA0; // 1010 0000 spc700.A = 0xA0; // 1010 0000
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(immediate_value)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -117,13 +208,13 @@ TEST_F(SPC700Test, ExecuteORWithImmediate) {
// EXPECT_EQ(spc700.PSW.N, 1); // EXPECT_EQ(spc700.PSW.N, 1);
} }
TEST_F(SPC700Test, ExecuteEORWithImmediate) { TEST_F(Spc700Test, ExecuteEORWithImmediate) {
// EOR A, imm // EOR A, imm
uint8_t opcode = 0x48; uint8_t opcode = 0x48;
uint8_t immediate_value = 0x5A; uint8_t immediate_value = 0x5A;
spc700.A = 0x5A; // 0101 1010 spc700.A = 0x5A; // 0101 1010
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(immediate_value)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(immediate_value));
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -132,7 +223,7 @@ TEST_F(SPC700Test, ExecuteEORWithImmediate) {
EXPECT_EQ(spc700.PSW.N, 0); EXPECT_EQ(spc700.PSW.N, 0);
} }
TEST_F(SPC700Test, ExecuteINC) { TEST_F(Spc700Test, ExecuteINC) {
// INC A // INC A
uint8_t opcode = 0xBC; uint8_t opcode = 0xBC;
spc700.A = 0xFF; spc700.A = 0xFF;
@@ -144,7 +235,7 @@ TEST_F(SPC700Test, ExecuteINC) {
EXPECT_EQ(spc700.PSW.N, 0); EXPECT_EQ(spc700.PSW.N, 0);
} }
TEST_F(SPC700Test, ExecuteDEC) { TEST_F(Spc700Test, ExecuteDEC) {
// DEC A // DEC A
uint8_t opcode = 0x9C; uint8_t opcode = 0x9C;
spc700.A = 0x01; spc700.A = 0x01;
@@ -156,13 +247,13 @@ TEST_F(SPC700Test, ExecuteDEC) {
EXPECT_EQ(spc700.PSW.N, 0); EXPECT_EQ(spc700.PSW.N, 0);
} }
TEST_F(SPC700Test, ExecuteBNEWhenNotEqual) { TEST_F(Spc700Test, ExecuteBNEWhenNotEqual) {
// BNE // BNE
uint8_t opcode = 0xD0; uint8_t opcode = 0xD0;
int8_t offset = 0x05; int8_t offset = 0x05;
spc700.PSW.Z = 0; spc700.PSW.Z = 0;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(offset)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(offset));
uint16_t initialPC = spc700.PC + 1; uint16_t initialPC = spc700.PC + 1;
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -170,13 +261,13 @@ TEST_F(SPC700Test, ExecuteBNEWhenNotEqual) {
EXPECT_EQ(spc700.PC, initialPC + offset); EXPECT_EQ(spc700.PC, initialPC + offset);
} }
TEST_F(SPC700Test, ExecuteBNEWhenEqual) { TEST_F(Spc700Test, ExecuteBNEWhenEqual) {
// BNE // BNE
uint8_t opcode = 0xD0; uint8_t opcode = 0xD0;
int8_t offset = 0x05; int8_t offset = 0x05;
spc700.PSW.Z = 1; spc700.PSW.Z = 1;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(offset)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(offset));
uint16_t initialPC = spc700.PC; uint16_t initialPC = spc700.PC;
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -184,13 +275,13 @@ TEST_F(SPC700Test, ExecuteBNEWhenEqual) {
EXPECT_EQ(spc700.PC, initialPC + 1); // +1 because of reading the offset EXPECT_EQ(spc700.PC, initialPC + 1); // +1 because of reading the offset
} }
TEST_F(SPC700Test, ExecuteBEQWhenEqual) { TEST_F(Spc700Test, ExecuteBEQWhenEqual) {
// BEQ // BEQ
uint8_t opcode = 0xF0; uint8_t opcode = 0xF0;
int8_t offset = 0x05; int8_t offset = 0x05;
spc700.PSW.Z = 1; spc700.PSW.Z = 1;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(offset)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(offset));
uint16_t initialPC = spc700.PC + 1; uint16_t initialPC = spc700.PC + 1;
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -198,13 +289,13 @@ TEST_F(SPC700Test, ExecuteBEQWhenEqual) {
EXPECT_EQ(spc700.PC, initialPC + offset); EXPECT_EQ(spc700.PC, initialPC + offset);
} }
TEST_F(SPC700Test, ExecuteBEQWhenNotEqual) { TEST_F(Spc700Test, ExecuteBEQWhenNotEqual) {
// BEQ // BEQ
uint8_t opcode = 0xF0; uint8_t opcode = 0xF0;
int8_t offset = 0x05; int8_t offset = 0x05;
spc700.PSW.Z = 0; spc700.PSW.Z = 0;
EXPECT_CALL(audioRAM, read(_)).WillOnce(testing::Return(offset)); EXPECT_CALL(audioRAM, read(_)).WillOnce(Return(offset));
uint16_t initialPC = spc700.PC; uint16_t initialPC = spc700.PC;
spc700.ExecuteInstructions(opcode); spc700.ExecuteInstructions(opcode);
@@ -212,6 +303,13 @@ TEST_F(SPC700Test, ExecuteBEQWhenNotEqual) {
EXPECT_EQ(spc700.PC, initialPC + 1); // +1 because of reading the offset EXPECT_EQ(spc700.PC, initialPC + 1); // +1 because of reading the offset
} }
TEST_F(Spc700Test, BootIplRomOk) {
// Boot the IPL ROM
// spc700.BootIplRom();
EXPECT_EQ(spc700.PC, 0xFFC1 + 0x3F);
}
} // namespace emu } // namespace emu
} // namespace app } // namespace app
} // namespace yaze } // namespace yaze