From 3a940a0cc2f76e71dd1bcae5a85a5210c0621d39 Mon Sep 17 00:00:00 2001
From: scawful <justin.scofield@outlook.com>
Date: Sun, 28 Sep 2025 03:07:45 -0400
Subject: [PATCH] Refactor Info.plist creation in release workflows for
 improved readability

- Replaced the heredoc syntax with echo commands to create the Info.plist file in both release-complex.yml and release-simplified.yml.
- This change enhances clarity and maintainability of the plist generation process.
---
 .github/workflows/release-complex.yml    | 38 +++++++++++-------------
 .github/workflows/release-simplified.yml | 38 +++++++++++-------------
 2 files changed, 36 insertions(+), 40 deletions(-)

diff --git a/.github/workflows/release-complex.yml b/.github/workflows/release-complex.yml
index 6cfaa697..878e1ce1 100644
--- a/.github/workflows/release-complex.yml
+++ b/.github/workflows/release-complex.yml
@@ -176,26 +176,24 @@ jobs:
                 else
                   # Create a basic Info.plist
                   VERSION_NUM=$(echo "${{ needs.validate-and-prepare.outputs.tag_name }}" | sed 's/^v//')
-                  cat > "Yaze.app/Contents/Info.plist" <<EOF
-                  <?xml version="1.0" encoding="UTF-8"?>
-                  <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-                  <plist version="1.0">
-                  <dict>
-                  <key>CFBundleExecutable</key>
-                  <string>yaze</string>
-                  <key>CFBundleIdentifier</key>
-                  <string>com.yaze.editor</string>
-                  <key>CFBundleName</key>
-                  <string>Yaze</string>
-                  <key>CFBundleVersion</key>
-                  <string>$VERSION_NUM</string>
-                  <key>CFBundleShortVersionString</key>
-                  <string>$VERSION_NUM</string>
-                  <key>CFBundlePackageType</key>
-                  <string>APPL</string>
-                  </dict>
-                  </plist>
-                  EOF
+                  echo '<?xml version="1.0" encoding="UTF-8"?>' > "Yaze.app/Contents/Info.plist"
+                  echo '<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">' >> "Yaze.app/Contents/Info.plist"
+                  echo '<plist version="1.0">' >> "Yaze.app/Contents/Info.plist"
+                  echo '<dict>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<key>CFBundleExecutable</key>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<string>yaze</string>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<key>CFBundleIdentifier</key>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<string>com.yaze.editor</string>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<key>CFBundleName</key>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<string>Yaze</string>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<key>CFBundleVersion</key>' >> "Yaze.app/Contents/Info.plist"
+                  echo "<string>$VERSION_NUM</string>" >> "Yaze.app/Contents/Info.plist"
+                  echo '<key>CFBundleShortVersionString</key>' >> "Yaze.app/Contents/Info.plist"
+                  echo "<string>$VERSION_NUM</string>" >> "Yaze.app/Contents/Info.plist"
+                  echo '<key>CFBundlePackageType</key>' >> "Yaze.app/Contents/Info.plist"
+                  echo '<string>APPL</string>' >> "Yaze.app/Contents/Info.plist"
+                  echo '</dict>' >> "Yaze.app/Contents/Info.plist"
+                  echo '</plist>' >> "Yaze.app/Contents/Info.plist"
                 fi
               fi
               
diff --git a/.github/workflows/release-simplified.yml b/.github/workflows/release-simplified.yml
index 3c2509e3..32b37e1a 100644
--- a/.github/workflows/release-simplified.yml
+++ b/.github/workflows/release-simplified.yml
@@ -345,26 +345,24 @@ jobs:
             cp -r assets "Yaze.app/Contents/Resources/" 2>/dev/null || echo "assets directory not found"
             # Create Info.plist with correct version
             VERSION_NUM=$(echo "${{ needs.validate-and-prepare.outputs.tag_name }}" | sed 's/^v//')
-            cat > "Yaze.app/Contents/Info.plist" <<EOF
-          <?xml version="1.0" encoding="UTF-8"?>
-          <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-          <plist version="1.0">
-          <dict>
-          <key>CFBundleExecutable</key>
-          <string>yaze</string>
-          <key>CFBundleIdentifier</key>
-          <string>com.yaze.editor</string>
-          <key>CFBundleName</key>
-          <string>Yaze</string>
-          <key>CFBundleVersion</key>
-          <string>$VERSION_NUM</string>
-          <key>CFBundleShortVersionString</key>
-          <string>$VERSION_NUM</string>
-          <key>CFBundlePackageType</key>
-          <string>APPL</string>
-          </dict>
-          </plist>
-          EOF
+            echo '<?xml version="1.0" encoding="UTF-8"?>' > "Yaze.app/Contents/Info.plist"
+            echo '<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">' >> "Yaze.app/Contents/Info.plist"
+            echo '<plist version="1.0">' >> "Yaze.app/Contents/Info.plist"
+            echo '<dict>' >> "Yaze.app/Contents/Info.plist"
+            echo '<key>CFBundleExecutable</key>' >> "Yaze.app/Contents/Info.plist"
+            echo '<string>yaze</string>' >> "Yaze.app/Contents/Info.plist"
+            echo '<key>CFBundleIdentifier</key>' >> "Yaze.app/Contents/Info.plist"
+            echo '<string>com.yaze.editor</string>' >> "Yaze.app/Contents/Info.plist"
+            echo '<key>CFBundleName</key>' >> "Yaze.app/Contents/Info.plist"
+            echo '<string>Yaze</string>' >> "Yaze.app/Contents/Info.plist"
+            echo '<key>CFBundleVersion</key>' >> "Yaze.app/Contents/Info.plist"
+            echo "<string>$VERSION_NUM</string>" >> "Yaze.app/Contents/Info.plist"
+            echo '<key>CFBundleShortVersionString</key>' >> "Yaze.app/Contents/Info.plist"
+            echo "<string>$VERSION_NUM</string>" >> "Yaze.app/Contents/Info.plist"
+            echo '<key>CFBundlePackageType</key>' >> "Yaze.app/Contents/Info.plist"
+            echo '<string>APPL</string>' >> "Yaze.app/Contents/Info.plist"
+            echo '</dict>' >> "Yaze.app/Contents/Info.plist"
+            echo '</plist>' >> "Yaze.app/Contents/Info.plist"
           fi
           
           # Create DMG