Refactor SnesToPc and PcToSnes functions for improved readability and consistency; remove redundant core:: namespace usage

src/app/core/common.cc

@@ -56,15 +56,6 @@ uint32_t ldle3(uint8_t const *const p_arr) { return ldle(p_arr, 3); }
 
 }  // namespace
 
-uint32_t Get24LocalFromPC(uint8_t *data, int addr, bool pc) {
-  uint32_t ret =
-      (PcToSnes(addr) & 0xFF0000) | (data[addr + 1] << 8) | data[addr];
-  if (pc) {
-    return SnesToPc(ret);
-  }
-  return ret;
-}
-
 void stle16b_i(uint8_t *const p_arr, size_t const p_index,
                uint16_t const p_val) {
   stle16b(p_arr + (p_index * 2), p_val);

src/app/core/common.h

@@ -18,41 +18,6 @@ namespace yaze {
  */
 namespace core {
 
-constexpr uint32_t kFastRomRegion = 0x808000;
-
-inline uint32_t SnesToPc(uint32_t addr) noexcept {
-  if (addr >= kFastRomRegion) {
-    addr -= kFastRomRegion;
-  }
-  uint32_t temp = (addr & 0x7FFF) + ((addr / 2) & 0xFF8000);
-  return (temp + 0x0);
-}
-
-inline uint32_t PcToSnes(uint32_t addr) {
-  uint8_t *b = reinterpret_cast<uint8_t *>(&addr);
-  b[2] = static_cast<uint8_t>(b[2] * 2);
-
-  if (b[1] >= 0x80) {
-    b[2] += 1;
-  } else {
-    b[1] += 0x80;
-  }
-
-  return addr;
-}
-
-inline int AddressFromBytes(uint8_t bank, uint8_t high, uint8_t low) noexcept {
-  return (bank << 16) | (high << 8) | low;
-}
-
-inline uint32_t MapBankToWordAddress(uint8_t bank, uint16_t addr) noexcept {
-  uint32_t result = 0;
-  result = (bank << 16) | addr;
-  return result;
-}
-
-uint32_t Get24LocalFromPC(uint8_t *data, int addr, bool pc = true);
-
 /**
  * @brief Store little endian 16-bit value using a byte pointer, offset by an
  * index before dereferencing