scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug: fix copy elision issue with test functions

Browse Source
This commit is contained in:
scawful
2022-08-17 14:46:45 -04:00
parent 35ce31980e
commit 5275a773b7
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/rom_test.cc
View File

@@ -26,7 +26,8 @@ Bytes ExpectCompressOk(ROM& rom, uchar* in, int in_size) {
EXPECT_TRUE(load_status.ok()); EXPECT_TRUE(load_status.ok());
auto compression_status = rom.Compress(0, in_size); auto compression_status = rom.Compress(0, in_size);
EXPECT_TRUE(compression_status.ok()); EXPECT_TRUE(compression_status.ok());
return std::move(*compression_status); auto compressed_bytes = std::move(*compression_status);
return compressed_bytes;
} }
Bytes ExpectDecompressOk(ROM& rom, uchar* in, int in_size) { Bytes ExpectDecompressOk(ROM& rom, uchar* in, int in_size) {
@@ -34,7 +35,8 @@ Bytes ExpectDecompressOk(ROM& rom, uchar* in, int in_size) {
EXPECT_TRUE(load_status.ok()); EXPECT_TRUE(load_status.ok());
auto decompression_status = rom.Decompress(0, in_size); auto decompression_status = rom.Decompress(0, in_size);
EXPECT_TRUE(decompression_status.ok()); EXPECT_TRUE(decompression_status.ok());
return std::move(*decompression_status); auto decompressed_bytes = std::move(*decompression_status);
return decompressed_bytes;
} }
std::shared_ptr<CompressionPiece> ExpectNewCompressionPieceOk( std::shared_ptr<CompressionPiece> ExpectNewCompressionPieceOk(
@@ -43,7 +45,7 @@ std::shared_ptr<CompressionPiece> ExpectNewCompressionPieceOk(
auto new_piece = std::make_shared<CompressionPiece>(command, length, args, auto new_piece = std::make_shared<CompressionPiece>(command, length, args,
argument_length); argument_length);
EXPECT_TRUE(new_piece != nullptr); EXPECT_TRUE(new_piece != nullptr);
return std::move(new_piece); return new_piece;
} }
} // namespace } // namespace
@@ -97,7 +99,7 @@ TEST(ROMTest, DecompressionMixingCommand) {
EXPECT_THAT(random1_o, ElementsAreArray(decomp_result.data(), 9)); EXPECT_THAT(random1_o, ElementsAreArray(decomp_result.data(), 9));
} }
/* Extended Header Command is currently unimplemented // Extended Header Command is currently unimplemented
TEST(ROMTest, ExtendedHeaderDecompress) { TEST(ROMTest, ExtendedHeaderDecompress) {
ROM rom; ROM rom;
uchar extendedcmd_i[4] = {0b11100100, 0x8F, 0x2A, 0xFF}; uchar extendedcmd_i[4] = {0b11100100, 0x8F, 0x2A, 0xFF};
@@ -123,7 +125,7 @@ TEST(ROMTest, ExtendedHeaderDecompress2) {
ASSERT_EQ(extendedcmd_o[i], data[i]); ASSERT_EQ(extendedcmd_o[i], data[i]);
} }
} }
*/
TEST(ROMTest, CompressionSingleSet) { TEST(ROMTest, CompressionSingleSet) {
ROM rom; ROM rom;