refactor: Improve code readability by applying consistent formatting and using absl::StrContains for string checks

This commit is contained in:
scawful
2025-10-03 21:11:51 -04:00
parent db227c9de5
commit 5419633c52
4 changed files with 67 additions and 38 deletions

View File

@@ -5,6 +5,7 @@
#include <vector>
#include "absl/strings/str_cat.h"
#include "absl/strings/match.h"
#include "app/core/platform/file_dialog.h"
#include "app/gui/icons.h"
#include "app/gui/modules/text_editor.h"
@@ -21,11 +22,11 @@ std::vector<std::string> RemoveIgnoredFiles(
std::vector<std::string> filtered_files;
for (const auto& file : files) {
// Remove subdirectory files
if (file.contains('/')) {
if (absl::StrContains(file, '/')) {
continue;
}
// Make sure the file has an extension
if (!file.contains('.')) {
if (!absl::StrContains(file, '.')) {
continue;
}
if (std::ranges::find(ignored_files, file) == ignored_files.end()) {
@@ -66,11 +67,11 @@ FolderItem LoadFolder(const std::string& folder) {
auto folder_files = FileDialogWrapper::GetFilesInFolder(full_folder);
for (const auto& files : folder_files) {
// Remove subdirectory files
if (files.contains('/')) {
if (absl::StrContains(files, '/')) {
continue;
}
// Make sure the file has an extension
if (!files.contains('.')) {
if (!absl::StrContains(files, '.')) {
continue;
}
if (std::ranges::find(ignored_files, files) != ignored_files.end()) {

View File

@@ -6,9 +6,11 @@
#include <string>
#include <unordered_map>
#include <vector>
#include <string_view>
#include "absl/strings/str_format.h"
#include "absl/strings/str_replace.h"
#include "absl/strings/match.h"
#include "app/rom.h"
namespace yaze {
@@ -59,7 +61,7 @@ struct DictionaryEntry {
}
bool ContainedInString(std::string_view s) const {
return s.contains(Contents);
return absl::StrContains(s, Contents);
}
std::string ReplaceInstancesOfIn(std::string_view s) const {