From 684959634c257935a600ed53c7c659dad60b917f Mon Sep 17 00:00:00 2001
From: scawful <justin.scofield@outlook.com>
Date: Sat, 8 Mar 2025 00:31:39 -0500
Subject: [PATCH] Refactor CreateAndRenderBitmap in Renderer class: change
 return type to void, improve error handling for palette setting

---
 src/app/core/platform/renderer.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/app/core/platform/renderer.h b/src/app/core/platform/renderer.h
index 0397f375..19b584d1 100644
--- a/src/app/core/platform/renderer.h
+++ b/src/app/core/platform/renderer.h
@@ -56,14 +56,14 @@ class Renderer {
     bitmap->UpdateTexture(renderer_.get());
   }
 
-  absl::Status CreateAndRenderBitmap(int width, int height, int depth,
-                                     const std::vector<uint8_t> &data,
-                                     gfx::Bitmap &bitmap,
-                                     gfx::SnesPalette &palette) {
+  void CreateAndRenderBitmap(int width, int height, int depth,
+                             const std::vector<uint8_t> &data,
+                             gfx::Bitmap &bitmap, gfx::SnesPalette &palette) {
     bitmap.Create(width, height, depth, data);
-    RETURN_IF_ERROR(bitmap.SetPalette(palette));
+    if (!bitmap.SetPalette(palette).ok()) {
+      throw std::runtime_error("Failed to set palette");
+    }
     RenderBitmap(&bitmap);
-    return absl::OkStatus();
   }
 
  private: