scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add out of range error in Rom class write functions, test Write fns

Browse Source
This commit is contained in:
scawful
2024-08-14 01:04:50 -04:00
parent f7a3d6cb8b
commit 6b35fcb07e
2 changed files with 68 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/app/rom.h
View File

@@ -301,8 +301,9 @@ class Rom : public core::ExperimentFlags {
}
absl::Status WriteByte(int addr, uint8_t value) {
RETURN_IF_ERROR(ReadWritePreconditions());
if (addr >= rom_data_.size()) {
return absl::InvalidArgumentError(absl::StrFormat(
return absl::OutOfRangeError(absl::StrFormat(
"Attempt to write byte %#02x value failed, address %d out of range",
value, addr));
}
@@ -314,8 +315,9 @@ class Rom : public core::ExperimentFlags {
}
absl::Status WriteWord(int addr, uint16_t value) {
RETURN_IF_ERROR(ReadWritePreconditions());
if (addr + 1 >= rom_data_.size()) {
return absl::InvalidArgumentError(absl::StrFormat(
return absl::OutOfRangeError(absl::StrFormat(
"Attempt to write word %#04x value failed, address %d out of range",
value, addr));
}
@@ -327,8 +329,9 @@ class Rom : public core::ExperimentFlags {
}
absl::Status WriteShort(int addr, uint16_t value) {
RETURN_IF_ERROR(ReadWritePreconditions());
if (addr + 1 >= rom_data_.size()) {
return absl::InvalidArgumentError(absl::StrFormat(
return absl::OutOfRangeError(absl::StrFormat(
"Attempt to write short %#04x value failed, address %d out of range",
value, addr));
}
@@ -340,8 +343,9 @@ class Rom : public core::ExperimentFlags {
}
absl::Status WriteLong(uint32_t addr, uint32_t value) {
RETURN_IF_ERROR(ReadWritePreconditions());
if (addr + 2 >= rom_data_.size()) {
return absl::InvalidArgumentError(absl::StrFormat(
return absl::OutOfRangeError(absl::StrFormat(
"Attempt to write long %#06x value failed, address %d out of range",
value, addr));
}