refactor(editor): remove EditorCardManager references from various editors

- Eliminated the inclusion of EditorCardManager from multiple editor header files, streamlining dependencies and reducing coupling.
- Updated comments in PaletteEditor to reflect the transition to EditorCardRegistry for card management.

Benefits:
- Enhances modularity by decoupling editor components from the centralized card manager.
- Improves maintainability and clarity in the codebase by aligning with the new card management approach.
This commit is contained in:
scawful
2025-10-15 16:55:07 -04:00
parent 49c59191ac
commit 7ee8f90574
15 changed files with 11 additions and 1311 deletions

View File

@@ -104,8 +104,6 @@ void UICoordinator::DrawAllUI() {
// Note: Theme styling is applied by ThemeManager, not here
// This is called from EditorManager::Update() - don't call menu bar stuff here
LOG_INFO("UICoordinator", "DrawAllUI() called");
// Draw UI windows and dialogs
// Session dialogs are drawn by SessionCoordinator separately to avoid duplication
DrawCommandPalette(); // Ctrl+Shift+P
@@ -114,8 +112,6 @@ void UICoordinator::DrawAllUI() {
DrawWelcomeScreen(); // Welcome screen
DrawProjectHelp(); // Project help
DrawWindowManagementUI(); // Window management
LOG_INFO("UICoordinator", "DrawAllUI() complete");
}
void UICoordinator::DrawMenuBarExtras() {
@@ -291,26 +287,20 @@ void UICoordinator::DrawWelcomeScreen() {
return;
}
LOG_INFO("UICoordinator", "Drawing welcome screen (rom_loaded=%s)",
rom_is_loaded ? "true" : "false");
// Reset first show flag to override ImGui ini state
// This ensures the window appears even if imgui.ini has it hidden
welcome_screen_->ResetFirstShow();
// Update recent projects before showing
welcome_screen_->RefreshRecentProjects();
// Show the welcome screen (it manages its own ImGui window)
// Show the welcome screen window
bool is_open = true;
bool action_taken = welcome_screen_->Show(&is_open);
welcome_screen_->Show(&is_open);
// If user closed the window via X button, mark as manually closed
// If user closed it via X button, respect that
if (!is_open) {
welcome_screen_manually_closed_ = true;
show_welcome_screen_ = false;
welcome_screen_->MarkManuallyClosed();
LOG_INFO("UICoordinator", "Welcome screen manually closed by user (X button)");
welcome_screen_manually_closed_ = true;
}
// If an action was taken (ROM loaded, project opened), the welcome screen will auto-hide
@@ -533,8 +523,6 @@ void UICoordinator::DrawTestingUI() {
void UICoordinator::DrawCommandPalette() {
if (!show_command_palette_) return;
LOG_INFO("UICoordinator", "DrawCommandPalette() - rendering command palette");
using namespace ImGui;
auto& theme = gui::ThemeManager::Get().GetCurrentTheme();

View File

@@ -92,10 +92,7 @@ class UICoordinator {
void HideCurrentEditorCards();
void ToggleCardSidebar() { show_card_sidebar_ = !show_card_sidebar_; }
void ShowGlobalSearch() { show_global_search_ = true; }
void ShowCommandPalette() {
LOG_INFO("UICoordinator", "ShowCommandPalette() called - setting flag to true");
show_command_palette_ = true;
}
void ShowCommandPalette() { show_command_palette_ = true; }
void ShowCardBrowser() { show_card_browser_ = true; }
// Window visibility management