From 8da0cc40ef70b7ba0bbff27e9dbe87e464919ff6 Mon Sep 17 00:00:00 2001
From: scawful <justin.scofield@outlook.com>
Date: Sat, 11 Oct 2025 21:50:30 -0400
Subject: [PATCH] chore(ci, release): enable tests for full builds and clarify
 build configurations

- Updated CI and release workflows to enable tests during full builds, ensuring comprehensive testing before releases.
- Added notes to clarify that the builds match release configurations and included a summary of features enabled in the build.
- Improved status messages for better visibility of build configurations and features.

Benefits:
- Enhanced testing coverage for pre-1.0 releases.
- Improved clarity in build configurations and feature availability.
---
 .github/workflows/ci.yml      |  7 ++++---
 .github/workflows/release.yml | 16 ++++++++++------
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ae487bf4..071b717e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -227,8 +227,8 @@ jobs:
           -DCMAKE_CXX_FLAGS="/Dgoogle_protobuf_undef_DWORD=1" `
           -DYAZE_BUILD_TESTS=ON `
           -DYAZE_BUILD_EMU=OFF `
-          -DYAZE_MINIMAL_BUILD=ON `
           -DYAZE_ENABLE_ROM_TESTS=OFF 2>&1 | Tee-Object -FilePath cmake_config.log
+        # Note: Full-featured build to match release configuration
         # Note: YAZE_BUILD_EMU=OFF disables standalone emulator executable
         #       but yaze_emulator library is still built for main app/tests
         
@@ -252,9 +252,9 @@ jobs:
           -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \
           -DYAZE_BUILD_TESTS=ON \
           -DYAZE_BUILD_EMU=OFF \
-          -DYAZE_MINIMAL_BUILD=ON \
           -DYAZE_ENABLE_ROM_TESTS=OFF 2>&1 | tee cmake_config.log
         echo "::endgroup::"
+        # Note: Full-featured build to match release configuration
         # Note: YAZE_BUILD_EMU=OFF disables standalone emulator executable
         #       but yaze_emulator library is still built for main app/tests
     
@@ -428,7 +428,8 @@ jobs:
         echo "- **Platform**: ${{ matrix.os }}" >> $GITHUB_STEP_SUMMARY
         echo "- **Compiler**: ${{ matrix.cc }}/${{ matrix.cxx }}" >> $GITHUB_STEP_SUMMARY
         echo "- **Build Type**: ${{ env.BUILD_TYPE }}" >> $GITHUB_STEP_SUMMARY
-        echo "- **Build Mode**: Full (same as release)" >> $GITHUB_STEP_SUMMARY
+        echo "- **Build Mode**: Full (matches release)" >> $GITHUB_STEP_SUMMARY
+        echo "- **Features**: gRPC, JSON, AI, ImGui Test Engine" >> $GITHUB_STEP_SUMMARY
         if [[ "${{ runner.os }}" == "Windows" ]]; then
           echo "- **vcpkg Triplet**: x64-windows-static" >> $GITHUB_STEP_SUMMARY
           if [[ "${{ steps.vcpkg.outcome }}" != "" ]]; then
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 4a04d15d..6708bcca 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -211,8 +211,10 @@ jobs:
             -DVCPKG_TARGET_TRIPLET=x64-windows-static `
             -DVCPKG_MANIFEST_MODE=ON `
             -DCMAKE_CXX_FLAGS="/Dgoogle_protobuf_undef_DWORD=1" `
-            -DYAZE_MINIMAL_BUILD=OFF `
-            -DYAZE_BUILD_TESTS=OFF 2>&1 | Tee-Object -FilePath cmake_config.log
+            -DYAZE_BUILD_TESTS=ON `
+            -DYAZE_ENABLE_ROM_TESTS=OFF 2>&1 | Tee-Object -FilePath cmake_config.log
+          # Note: Tests enabled for pre-1.0 releases to catch issues before publishing
+          # ROM tests disabled (require test ROM file)
 
           if ($LASTEXITCODE -ne 0) {
             Write-Host "::error::CMake configuration failed with exit code $LASTEXITCODE"
@@ -232,11 +234,12 @@ jobs:
             -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} \
             -DCMAKE_OSX_ARCHITECTURES=${{ matrix.mac_arch }} \
             -DYAZE_BUILD_EMU=OFF \
-            -DYAZE_MINIMAL_BUILD=OFF \
-            -DYAZE_BUILD_TESTS=OFF 2>&1 | tee cmake_config.log
+            -DYAZE_BUILD_TESTS=ON \
+            -DYAZE_ENABLE_ROM_TESTS=OFF 2>&1 | tee cmake_config.log
           echo "::endgroup::"
           # Note: YAZE_BUILD_EMU=OFF disables standalone emulator executable
           #       but yaze_emulator library is still built for main app
+          # Note: Tests enabled for pre-1.0 releases to catch issues before publishing
 
       - name: "Configure (Linux)"
         if: runner.os == 'Linux'
@@ -248,11 +251,12 @@ jobs:
           cmake -B build -G Ninja \
             -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} \
             -DYAZE_BUILD_EMU=OFF \
-            -DYAZE_MINIMAL_BUILD=OFF \
-            -DYAZE_BUILD_TESTS=OFF 2>&1 | tee cmake_config.log
+            -DYAZE_BUILD_TESTS=ON \
+            -DYAZE_ENABLE_ROM_TESTS=OFF 2>&1 | tee cmake_config.log
           echo "::endgroup::"
           # Note: YAZE_BUILD_EMU=OFF disables standalone emulator executable
           #       but yaze_emulator library is still built for main app
+          # Note: Tests enabled for pre-1.0 releases to catch issues before publishing
 
       - name: "Report Configure Failure"
         if: |