scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(editor): improve visibility management for card-based editors

Browse Source 
- Updated EditorManager to pass visibility flags directly to memory and assembly editors, enhancing the responsiveness of the editor interface.
- Simplified visibility checks by retrieving flags from the EditorCardManager, ensuring accurate updates based on user interactions.

Benefits:
- Streamlines the editor update process, improving user experience by ensuring editors reflect their visibility state accurately.
This commit is contained in:
scawful
2025-10-12 20:52:37 -04:00
parent e5aff24bfc
commit a2e219c33b
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/app/editor/editor_manager.cc
View File

@@ -1568,15 +1568,19 @@ void EditorManager::DrawMenuBar() {
ShowMetricsWindow(&show_imgui_metrics_); ShowMetricsWindow(&show_imgui_metrics_);
auto& card_manager = gui::EditorCardManager::Get(); auto& card_manager = gui::EditorCardManager::Get();
if (card_manager.IsCardVisible("memory.hex_editor") && current_editor_set_) { if (current_editor_set_) {
bool show_memory = true; // Pass the actual visibility flag pointer so the X button works
current_editor_set_->memory_editor_.Update(show_memory); bool* hex_visibility = card_manager.GetVisibilityFlag("memory.hex_editor");
if (hex_visibility && *hex_visibility) {
current_editor_set_->memory_editor_.Update(*hex_visibility);
}
bool* assembly_visibility = card_manager.GetVisibilityFlag("assembly.editor");
if (assembly_visibility && *assembly_visibility) {
current_editor_set_->assembly_editor_.Update(*card_manager.GetVisibilityFlag("assembly.editor"));
}
} }
if (card_manager.IsCardVisible("assembly.editor") && current_editor_set_) {
bool show_asm = true;
current_editor_set_->assembly_editor_.Update(show_asm);
}
// Project file editor // Project file editor
project_file_editor_.Draw(); project_file_editor_.Draw();
if (show_performance_dashboard_) { if (show_performance_dashboard_) {