remove magic numbers, enforce const correctness

src/app/editor/graphics/graphics_editor.cc

@@ -397,7 +397,7 @@ absl::Status GraphicsEditor::UpdateLinkGfxView() {
     int i = 0;
     for (auto link_sheet : *rom()->mutable_link_graphics()) {
       int x_offset = 0;
-      int y_offset = core::kTilesheetHeight * i * 4;
+      int y_offset = gfx::kTilesheetHeight * i * 4;
       link_canvas_.DrawContextMenu(&link_sheet);
       link_canvas_.DrawBitmap(link_sheet, x_offset, y_offset, 4);
       i++;
@@ -767,7 +767,7 @@ absl::Status GraphicsEditor::DecompressImportData(int size) {
                                      temp_rom_.data(), current_offset_, size))
 
   auto converted_sheet = gfx::SnesTo8bppSheet(import_data_, 3);
-  bin_bitmap_.Create(core::kTilesheetWidth, 0x2000, core::kTilesheetDepth,
+  bin_bitmap_.Create(gfx::kTilesheetWidth, 0x2000, gfx::kTilesheetDepth,
                      converted_sheet);
 
   if (rom()->is_loaded()) {
@@ -795,8 +795,8 @@ absl::Status GraphicsEditor::DecompressSuperDonkey() {
         auto decompressed_data,
         gfx::lc_lz2::DecompressV2(temp_rom_.data(), offset_value, 0x1000))
     auto converted_sheet = gfx::SnesTo8bppSheet(decompressed_data, 3);
-    gfx_sheets_[i] = gfx::Bitmap(core::kTilesheetWidth, core::kTilesheetHeight,
-                                 core::kTilesheetDepth, converted_sheet);
+    gfx_sheets_[i] = gfx::Bitmap(gfx::kTilesheetWidth, gfx::kTilesheetHeight,
+                                 gfx::kTilesheetDepth, converted_sheet);
     if (col_file_) {
       status_ = gfx_sheets_[i].ApplyPalette(
           col_file_palette_group_[current_palette_index_]);
@@ -820,8 +820,8 @@ absl::Status GraphicsEditor::DecompressSuperDonkey() {
         auto decompressed_data,
         gfx::lc_lz2::DecompressV2(temp_rom_.data(), offset_value, 0x1000))
     auto converted_sheet = gfx::SnesTo8bppSheet(decompressed_data, 3);
-    gfx_sheets_[i] = gfx::Bitmap(core::kTilesheetWidth, core::kTilesheetHeight,
-                                 core::kTilesheetDepth, converted_sheet);
+    gfx_sheets_[i] = gfx::Bitmap(gfx::kTilesheetWidth, gfx::kTilesheetHeight,
+                                 gfx::kTilesheetDepth, converted_sheet);
     if (col_file_) {
       status_ = gfx_sheets_[i].ApplyPalette(
           col_file_palette_group_[current_palette_index_]);

src/app/editor/graphics/graphics_editor.h

@@ -192,7 +192,7 @@ class GraphicsEditor : public SharedRom, public Editor {
                                     gui::CanvasGridSize::k8x8};
   gui::Canvas link_canvas_{
       "LinkCanvas",
-      ImVec2(core::kTilesheetWidth * 4, core::kTilesheetHeight * 0x10 * 4),
+      ImVec2(gfx::kTilesheetWidth * 4, gfx::kTilesheetHeight * 0x10 * 4),
       gui::CanvasGridSize::k16x16};
   absl::Status status_;
 };

src/app/editor/graphics/palette_editor.cc

@@ -1,13 +1,12 @@
 #include "palette_editor.h"
 
-#include "imgui/imgui.h"
-
 #include "absl/status/status.h"
 #include "app/gfx/snes_palette.h"
 #include "app/gui/canvas.h"
 #include "app/gui/color.h"
 #include "app/gui/icons.h"
 #include "app/gui/style.h"
+#include "imgui/imgui.h"
 
 namespace yaze {
 namespace app {

src/app/editor/graphics/screen_editor.cc

@@ -1,7 +1,5 @@
 #include "screen_editor.h"
 
-#include "imgui/imgui.h"
-
 #include <algorithm>
 #include <fstream>
 #include <iostream>
@@ -13,14 +11,15 @@
 #include "absl/strings/string_view.h"
 #include "app/core/common.h"
 #include "app/core/constants.h"
+#include "app/core/platform/renderer.h"
 #include "app/gfx/bitmap.h"
 #include "app/gfx/snes_tile.h"
 #include "app/gfx/tilesheet.h"
 #include "app/gui/canvas.h"
-#include "app/core/platform/renderer.h"
 #include "app/gui/icons.h"
 #include "app/gui/input.h"
 #include "app/zelda3/dungeon/room.h"
+#include "imgui/imgui.h"
 
 namespace yaze {
 namespace app {
@@ -28,6 +27,8 @@ namespace editor {
 
 using core::Renderer;
 
+constexpr uint32_t kRedPen = 0xFF0000FF;
+
 absl::Status ScreenEditor::Update() {
   TAB_BAR("##TabBar")
   TAB_ITEM("Dungeon Maps")
@@ -290,7 +291,7 @@ void ScreenEditor::DrawDungeonMapsTabs() {
 
             if (current_dungeon.floor_rooms[floor_number][j] == boss_room) {
               screen_canvas_.DrawOutlineWithColor((posX * 2), (posY * 2), 64,
-                                                  64, core::kRedPen);
+                                                  64, kRedPen);
             }
 
             std::string label =

src/app/editor/graphics/tile16_editor.h

@@ -84,7 +84,7 @@ class Tile16Editor : public context::GfxContext, public SharedRom {
   // Tile8 canvas to get the tile to drawing in the tile16_edit_canvas_
   gui::Canvas tile8_source_canvas_{
       "Tile8SourceCanvas",
-      ImVec2(core::kTilesheetWidth * 4, core::kTilesheetHeight * 0x10 * 4),
+      ImVec2(gfx::kTilesheetWidth * 4, gfx::kTilesheetHeight * 0x10 * 4),
       gui::CanvasGridSize::k32x32};
   gfx::Bitmap current_gfx_bmp_;