scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Update Test Status Enum and Compiler Options

Browse Source 
- Changed the enum values in GetTestStatusResponse from STATUS_* to TEST_STATUS_* for consistency and clarity.
- Updated corresponding references in imgui_test_harness_service.cc and gui_automation_client.cc to reflect the new enum naming.
- Added /EHsc compiler option in CMakeLists.txt for MSVC to enable C++ exception handling.
This commit is contained in:
scawful
2025-10-10 10:55:28 -04:00
parent b64ef74b10
commit b2701c8cec
4 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CMakeLists.txt
View File

@@ -280,6 +280,7 @@ endif()
# Compiler-specific settings # Compiler-specific settings
if(MSVC) if(MSVC)
target_compile_options(yaze_common INTERFACE target_compile_options(yaze_common INTERFACE
/EHsc
/W4 /permissive- /W4 /permissive-
/bigobj # Support large object files /bigobj # Support large object files
/utf-8 # Use UTF-8 encoding /utf-8 # Use UTF-8 encoding

14
src/app/core/service/imgui_test_harness_service.cc
View File

@@ -113,18 +113,18 @@ namespace {
::yaze::test::HarnessTestStatus status) { ::yaze::test::HarnessTestStatus status) {
switch (status) { switch (status) {
case ::yaze::test::HarnessTestStatus::kQueued: case ::yaze::test::HarnessTestStatus::kQueued:
return ::yaze::test::GetTestStatusResponse::STATUS_QUEUED; return ::yaze::test::GetTestStatusResponse::TEST_STATUS_QUEUED;
case ::yaze::test::HarnessTestStatus::kRunning: case ::yaze::test::HarnessTestStatus::kRunning:
return ::yaze::test::GetTestStatusResponse::STATUS_RUNNING; return ::yaze::test::GetTestStatusResponse::TEST_STATUS_RUNNING;
case ::yaze::test::HarnessTestStatus::kPassed: case ::yaze::test::HarnessTestStatus::kPassed:
return ::yaze::test::GetTestStatusResponse::STATUS_PASSED; return ::yaze::test::GetTestStatusResponse::TEST_STATUS_PASSED;
case ::yaze::test::HarnessTestStatus::kFailed: case ::yaze::test::HarnessTestStatus::kFailed:
return ::yaze::test::GetTestStatusResponse::STATUS_FAILED; return ::yaze::test::GetTestStatusResponse::TEST_STATUS_FAILED;
case ::yaze::test::HarnessTestStatus::kTimeout: case ::yaze::test::HarnessTestStatus::kTimeout:
return ::yaze::test::GetTestStatusResponse::STATUS_TIMEOUT; return ::yaze::test::GetTestStatusResponse::TEST_STATUS_TIMEOUT;
case ::yaze::test::HarnessTestStatus::kUnspecified: case ::yaze::test::HarnessTestStatus::kUnspecified:
default: default:
return ::yaze::test::GetTestStatusResponse::STATUS_UNSPECIFIED; return ::yaze::test::GetTestStatusResponse::TEST_STATUS_UNSPECIFIED;
} }
} }
@@ -1249,7 +1249,7 @@ absl::Status ImGuiTestHarnessServiceImpl::GetTestStatus(
auto execution_or = auto execution_or =
test_manager_->GetHarnessTestExecution(request->test_id()); test_manager_->GetHarnessTestExecution(request->test_id());
if (!execution_or.ok()) { if (!execution_or.ok()) {
response->set_status(GetTestStatusResponse::STATUS_UNSPECIFIED); response->set_status(GetTestStatusResponse::TEST_STATUS_UNSPECIFIED);
response->set_error_message(std::string(execution_or.status().message())); response->set_error_message(std::string(execution_or.status().message()));
return absl::OkStatus(); return absl::OkStatus();
} }

12
src/cli/service/gui/gui_automation_client.cc
View File

@@ -55,17 +55,17 @@ TestRunStatus ConvertStatusProto(
yaze::test::GetTestStatusResponse::TestStatus status) { yaze::test::GetTestStatusResponse::TestStatus status) {
using ProtoStatus = yaze::test::GetTestStatusResponse::TestStatus; using ProtoStatus = yaze::test::GetTestStatusResponse::TestStatus;
switch (status) { switch (status) {
case ProtoStatus::GetTestStatusResponse_TestStatus_STATUS_QUEUED: case ProtoStatus::GetTestStatusResponse_TestStatus_TEST_STATUS_QUEUED:
return TestRunStatus::kQueued; return TestRunStatus::kQueued;
case ProtoStatus::GetTestStatusResponse_TestStatus_STATUS_RUNNING: case ProtoStatus::GetTestStatusResponse_TestStatus_TEST_STATUS_RUNNING:
return TestRunStatus::kRunning; return TestRunStatus::kRunning;
case ProtoStatus::GetTestStatusResponse_TestStatus_STATUS_PASSED: case ProtoStatus::GetTestStatusResponse_TestStatus_TEST_STATUS_PASSED:
return TestRunStatus::kPassed; return TestRunStatus::kPassed;
case ProtoStatus::GetTestStatusResponse_TestStatus_STATUS_FAILED: case ProtoStatus::GetTestStatusResponse_TestStatus_TEST_STATUS_FAILED:
return TestRunStatus::kFailed; return TestRunStatus::kFailed;
case ProtoStatus::GetTestStatusResponse_TestStatus_STATUS_TIMEOUT: case ProtoStatus::GetTestStatusResponse_TestStatus_TEST_STATUS_TIMEOUT:
return TestRunStatus::kTimeout; return TestRunStatus::kTimeout;
case ProtoStatus::GetTestStatusResponse_TestStatus_STATUS_UNSPECIFIED: case ProtoStatus::GetTestStatusResponse_TestStatus_TEST_STATUS_UNSPECIFIED:
default: default:
return TestRunStatus::kUnknown; return TestRunStatus::kUnknown;
} }

12
src/protos/imgui_test_harness.proto
View File

@@ -159,12 +159,12 @@ message GetTestStatusRequest {
message GetTestStatusResponse { message GetTestStatusResponse {
enum TestStatus { enum TestStatus {
STATUS_UNSPECIFIED = 0; // Test ID not found or unspecified TEST_STATUS_UNSPECIFIED = 0; // Test ID not found or unspecified
STATUS_QUEUED = 1; // Waiting to execute TEST_STATUS_QUEUED = 1; // Waiting to execute
STATUS_RUNNING = 2; // Currently executing TEST_STATUS_RUNNING = 2; // Currently executing
STATUS_PASSED = 3; // Completed successfully TEST_STATUS_PASSED = 3; // Completed successfully
STATUS_FAILED = 4; // Assertion failed or error TEST_STATUS_FAILED = 4; // Assertion failed or error
STATUS_TIMEOUT = 5; // Exceeded timeout TEST_STATUS_TIMEOUT = 5; // Exceeded timeout
} }
TestStatus status = 1; TestStatus status = 1;