chore: reintroduce /WHOLEARCHIVE linking for protobuf at executable level

- Added /WHOLEARCHIVE linking for protobuf in various CMake files to ensure internal symbols are included while preventing resource duplication.
- Updated linking options for `yaze`, `yaze_emu`, `z3ed`, and test suites to apply this option conditionally on Windows with MSVC.

Benefits:
- Ensures proper inclusion of protobuf symbols in executables, improving compatibility and functionality across platforms.
This commit is contained in:
scawful
2025-10-18 01:54:58 -04:00
parent 41154fc425
commit b4d4195e47
5 changed files with 41 additions and 4 deletions

View File

@@ -47,8 +47,12 @@ if(YAZE_BUILD_TESTS)
message(STATUS "Configuring Windows stack size for ${suite_name} to 16MB")
if(MSVC)
target_link_options(${suite_name} PRIVATE /STACK:16777216)
# NOTE: Removed /WHOLEARCHIVE for protobuf - causes LNK1241 duplicate version.res
# Protobuf symbols are already linked transitively from yaze_test_support
# Apply /WHOLEARCHIVE only at executable level to prevent duplicate version.res
if(YAZE_WITH_GRPC AND YAZE_PROTOBUF_WHOLEARCHIVE_TARGETS)
foreach(_yaze_proto_target IN LISTS YAZE_PROTOBUF_WHOLEARCHIVE_TARGETS)
target_link_options(${suite_name} PRIVATE /WHOLEARCHIVE:$<TARGET_FILE:${_yaze_proto_target}>)
endforeach()
endif()
else()
target_link_options(${suite_name} PRIVATE -Wl,--stack,16777216)
endif()