scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Introduce UI Helper Functions and Refactor Color Management

Browse Source 
- Added ui_helpers.cc and ui_helpers.h to centralize UI-related helper functions, improving code organization and reducing boilerplate in ImGui usage.
- Refactored color management in BppFormatUI to utilize new helper functions for success, warning, and error colors, enhancing theming consistency.
- Updated AgentChatWidget and CanvasContextMenu to streamline UI rendering and improve maintainability by removing redundant code and enhancing functionality.
- Removed canvas_utils_moved.cc and canvas_utils_moved.h to clean up the project structure, consolidating utility functions into more appropriate locations.
This commit is contained in:
scawful
2025-10-05 15:19:18 -04:00
parent c3f03472c1
commit cd6a6d9478
11 changed files with 227 additions and 838 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/app/gui/bpp_format_ui.cc
View File

@@ -5,6 +5,7 @@
#include "app/gfx/bpp_format_manager.h"
#include "app/gfx/bitmap.h"
#include "app/gui/ui_helpers.h"
#include "imgui/imgui.h"
namespace yaze {
@@ -58,11 +59,11 @@ bool BppFormatUI::RenderFormatSelector(gfx::Bitmap* bitmap, const gfx::SnesPalet
ImVec4 efficiency_color;
if (efficiency >= 80) {
efficiency_color = ImVec4(0, 1, 0, 1); // Green
efficiency_color = GetSuccessColor(); // Green
} else if (efficiency >= 60) {
efficiency_color = ImVec4(1, 1, 0, 1); // Yellow
efficiency_color = GetWarningColor(); // Yellow
} else {
efficiency_color = ImVec4(1, 0, 0, 1); // Red
efficiency_color = GetErrorColor(); // Red
}
ImGui::TextColored(efficiency_color, "Quality: %s",
efficiency >= 80 ? "Excellent" :
@@ -140,13 +141,13 @@ void BppFormatUI::RenderAnalysisPanel(const gfx::Bitmap& bitmap, const gfx::Snes
ImGui::Text("Format Recommendations:");
if (used_colors <= 4) {
ImGui::TextColored(ImVec4(0, 1, 0, 1), "✓ 2BPP format would be optimal");
ImGui::TextColored(GetSuccessColor(), "✓ 2BPP format would be optimal");
} else if (used_colors <= 8) {
ImGui::TextColored(ImVec4(0, 1, 0, 1), "✓ 3BPP format would be optimal");
ImGui::TextColored(GetSuccessColor(), "✓ 3BPP format would be optimal");
} else if (used_colors <= 16) {
ImGui::TextColored(ImVec4(0, 1, 0, 1), "✓ 4BPP format would be optimal");
ImGui::TextColored(GetSuccessColor(), "✓ 4BPP format would be optimal");
} else {
ImGui::TextColored(ImVec4(1, 1, 0, 1), "⚠ 8BPP format is necessary");
ImGui::TextColored(GetWarningColor(), "⚠ 8BPP format is necessary");
}
// Memory usage comparison
@@ -257,10 +258,10 @@ void BppFormatUI::RenderSheetAnalysis(const std::vector<uint8_t>& sheet_data, in
gfx::BppFormatManager::Get().GetFormatInfo(analysis.current_format).name.c_str());
if (analysis.was_converted) {
ImGui::TextColored(ImVec4(1, 1, 0, 1), "⚠ This sheet was converted");
ImGui::TextColored(GetWarningColor(), "⚠ This sheet was converted");
ImGui::Text("Conversion History: %s", analysis.conversion_history.c_str());
} else {
ImGui::TextColored(ImVec4(0, 1, 0, 1), "✓ Original format preserved");
ImGui::TextColored(GetSuccessColor(), "✓ Original format preserved");
}
ImGui::Separator();
@@ -295,13 +296,13 @@ void BppFormatUI::RenderSheetAnalysis(const std::vector<uint8_t>& sheet_data, in
ImGui::Text("Recommendations:");
if (analysis.was_converted && analysis.palette_entries_used <= 16) {
ImGui::TextColored(ImVec4(0, 1, 0, 1),
ImGui::TextColored(GetSuccessColor(),
"✓ Consider reverting to %s format for better compression",
gfx::BppFormatManager::Get().GetFormatInfo(analysis.original_format).name.c_str());
}
if (analysis.palette_entries_used < static_cast<int>(palette.size()) / 2) {
ImGui::TextColored(ImVec4(1, 1, 0, 1),
ImGui::TextColored(GetWarningColor(),
"⚠ Palette is underutilized - consider optimization");
}