Add CPX, CPY, DEX, DEY, XCE, Emulation Mode

This commit is contained in:
scawful
2023-08-19 17:27:01 -04:00
parent 8d0f4110e0
commit d83d341b1e
4 changed files with 287 additions and 46 deletions

View File

@@ -334,23 +334,23 @@ void CPU::ExecuteInstruction(uint8_t opcode) {
break;
case 0xE0: // CPX Immediate
// CPX();
CPX(Immediate());
break;
case 0xE4: // CPX Direct Page
// CPX();
break;
case 0xEC: // CPX Absolute
// CPX();
CPX(Absolute());
break;
case 0xC0: // CPY Immediate
// CPY();
CPY(Immediate());
break;
case 0xC4: // CPY Direct Page
// CPY();
break;
case 0xCC: // CPY Absolute
// CPY();
CPY(Absolute());
break;
case 0x3A: // DEC Accumulator
@@ -370,11 +370,11 @@ void CPU::ExecuteInstruction(uint8_t opcode) {
break;
case 0xCA: // DEX Decrement X register
// DEX();
DEX();
break;
case 0x88: // DEY Decrement Y register
// DEY();
DEY();
break;
case 0x41: // EOR DP Indexed Indirect, X
@@ -951,7 +951,7 @@ void CPU::ExecuteInstruction(uint8_t opcode) {
break;
case 0xFB: // XCE
// XCE();
XCE();
break;
default:
std::cerr << "Unknown instruction: " << std::hex
@@ -962,7 +962,7 @@ void CPU::ExecuteInstruction(uint8_t opcode) {
void CPU::ADC(uint8_t operand) {
auto C = GetCarryFlag();
if (GetAccumulatorSize()) { // 8-bit mode
if (!E) { // 8-bit mode
uint16_t result = (A & 0xFF) + (operand & 0xFF); // + (C ? 1 : 0);
SetCarryFlag(!(result > 0xFF)); // Update the carry flag
@@ -997,7 +997,7 @@ void CPU::ADC(uint8_t operand) {
void CPU::AND(uint16_t address) {
uint8_t operand;
if (GetAccumulatorSize() == 0) { // 16-bit mode
if (E == 0) { // 16-bit mode
uint16_t operand16 = memory.ReadWord(address);
A &= operand16;
SetZeroFlag(A == 0);

View File

@@ -242,14 +242,14 @@ class CPU : public Memory {
// ==========================================================================
// Registers
uint8_t A = 0; // Accumulator
uint8_t X = 0; // X index register
uint8_t Y = 0; // Y index register
// uint8_t SP = 0; // Stack Pointer
uint16_t DB = 0; // Data Bank register
uint8_t A = 0; // Accumulator
uint8_t X = 0; // X index register
uint8_t Y = 0; // Y index register
uint16_t D = 0; // Direct Page register
uint16_t DB = 0; // Data Bank register
uint16_t PB = 0; // Program Bank register
uint16_t PC = 0; // Program Counter
uint8_t E = 1; // Emulation mode flag
uint8_t status; // Processor Status (P)
// Mnemonic Value Binary Description
@@ -312,12 +312,7 @@ class CPU : public Memory {
// CPX: Compare X register
// CPY: Compare Y register
// DEC: Decrement
// DEX: Decrement X register
// DEY: Decrement Y register
// EOR: Exclusive OR
// INC: Increment
// INX: Increment X register
// INY: Increment Y register
// JMP: Jump
// JML: Jump long
// JSR: Jump to subroutine
@@ -333,19 +328,6 @@ class CPU : public Memory {
// PEA: Push effective address
// PEI: Push effective indirect address
// PER: Push effective PC-relative address
// PHA: Push accumulator
// PHB: Push data bank register
// PHD: Push direct page register
// PHK: Push program bank register
// PHP: Push processor status register
// PHX: Push X register
// PHY: Push Y register
// PLA: Pull accumulator
// PLB: Pull data bank register
// PLD: Pull direct page register
// PLP: Pull processor status register
// PLX: Pull X register
// PLY: Pull Y register
// ROL: Rotate left
// ROR: Rotate right
// RTI: Return from interrupt
@@ -390,16 +372,86 @@ class CPU : public Memory {
PC++;
}
// SEC: Set carry flag
void SEC() { status |= 0x01; }
// CLC: Clear carry flag
void CLC() { status &= ~0x01; }
// CLD: Clear decimal mode
void CLD() { status &= ~0x08; }
// CLI: Clear interrupt disable flag
void CLI() { status &= ~0x04; }
// CLV: Clear overflow flag
void CLV() { status &= ~0x40; }
bool emulation_mode = false;
void CPX(uint16_t address) {
uint16_t memory_value =
E ? memory.ReadByte(address) : memory.ReadWord(address);
compare(X, memory_value);
}
void CPY(uint16_t address) {
uint16_t memory_value =
E ? memory.ReadByte(address) : memory.ReadWord(address);
compare(Y, memory_value);
}
// DEX: Decrement X register
void DEX() {
X--;
SetZeroFlag(X == 0);
SetNegativeFlag(X & 0x80);
}
// DEY: Decrement Y register
void DEY() {
Y--;
SetZeroFlag(Y == 0);
SetNegativeFlag(Y & 0x80);
}
// INX: Increment X register
void INX() {
X++;
SetNegativeFlag(X & 0x80);
SetZeroFlag(X == 0);
}
// INY: Increment Y register
void INY() {
Y++;
SetNegativeFlag(Y & 0x80);
SetZeroFlag(Y == 0);
}
// INC: Increment memory
void INC(uint16_t address) {
if (GetAccumulatorSize()) {
uint8_t value = ReadByte(address);
value++;
if (value == static_cast<uint8_t>(0x100)) {
value = 0x00; // Wrap around in 8-bit mode
}
WriteByte(address, value);
SetNegativeFlag(value & 0x80);
SetZeroFlag(value == 0);
} else {
uint16_t value = ReadWord(address);
value++;
if (value == static_cast<uint16_t>(0x10000)) {
value = 0x0000; // Wrap around in 16-bit mode
}
WriteByte(address, value);
SetNegativeFlag(value & 0x80);
SetZeroFlag(value == 0);
}
}
// Push Accumulator on Stack
void PHA() { memory.PushByte(A); }
@@ -535,19 +587,22 @@ class CPU : public Memory {
SetNegativeFlag(A & 0x80);
}
void INX() {
X++;
SetZeroFlag(X == 0);
SetNegativeFlag(X & 0x80);
}
void INY() {
Y++;
SetZeroFlag(Y == 0);
SetNegativeFlag(Y & 0x80);
// XCE: Exchange Carry and Emulation Flags
void XCE() {
uint8_t carry = status & 0x01;
status &= ~0x01;
status |= E;
E = carry;
}
private:
void compare(uint16_t register_value, uint16_t memory_value) {
uint16_t result = register_value - memory_value;
SetNegativeFlag(result & (E ? 0x8000 : 0x80)); // Negative flag
SetZeroFlag(result == 0); // Zero flag
SetCarryFlag(register_value >= 0); // Carry flag
}
// Helper function to set or clear a specific flag bit
void SetFlag(uint8_t mask, bool set) {
if (set) {

View File

@@ -74,8 +74,8 @@ class MemoryImpl : public Memory {
}
void WriteByte(uint32_t address, uint8_t value) override {
uint32_t mapped_address = GetMappedAddress(address);
memory_.at(mapped_address) = value;
// uint32_t mapped_address = GetMappedAddress(address);
memory_[address] = value;
}
void WriteWord(uint32_t address, uint16_t value) override {
uint32_t mapped_address = GetMappedAddress(address);