Refactor editor classes to accept a ROM pointer in constructors, enhancing dependency management and initialization across all editor types.

src/app/editor/graphics/graphics_editor.h

@@ -54,20 +54,28 @@ const std::string kSuperDonkeySprites[] = {
  * drawing toolsets, palette controls, clipboard imports, experimental features,
  * and memory editor.
  */
-class GraphicsEditor : public SharedRom, public Editor {
+class GraphicsEditor : public Editor {
  public:
-  GraphicsEditor() { type_ = EditorType::kGraphics; }
+  explicit GraphicsEditor(Rom* rom = nullptr) : rom_(rom) { 
+    type_ = EditorType::kGraphics; 
+  }
 
   void Initialize() override;
   absl::Status Load() override;
+  absl::Status Save() override { return absl::UnimplementedError("Save"); }
   absl::Status Update() override;
-  absl::Status Undo() override { return absl::UnimplementedError("Undo"); }
-  absl::Status Redo() override { return absl::UnimplementedError("Redo"); }
   absl::Status Cut() override { return absl::UnimplementedError("Cut"); }
   absl::Status Copy() override { return absl::UnimplementedError("Copy"); }
   absl::Status Paste() override { return absl::UnimplementedError("Paste"); }
+  absl::Status Undo() override { return absl::UnimplementedError("Undo"); }
+  absl::Status Redo() override { return absl::UnimplementedError("Redo"); }
   absl::Status Find() override { return absl::UnimplementedError("Find"); }
-  absl::Status Save() override { return absl::UnimplementedError("Save"); }
+  
+  // Set the ROM pointer
+  void set_rom(Rom* rom) { rom_ = rom; }
+  
+  // Get the ROM pointer
+  Rom* rom() const { return rom_; }
 
  private:
   enum class GfxEditMode {
@@ -195,6 +203,8 @@ class GraphicsEditor : public SharedRom, public Editor {
       ImVec2(gfx::kTilesheetWidth * 4, gfx::kTilesheetHeight * 0x10 * 4),
       gui::CanvasGridSize::k16x16};
   absl::Status status_;
+
+  Rom* rom_;
 };
 
 }  // namespace editor

src/app/editor/graphics/palette_editor.h

@@ -77,9 +77,9 @@ absl::Status DisplayPalette(gfx::SnesPalette& palette, bool loaded);
  * @class PaletteEditor
  * @brief Allows the user to view and edit in game palettes.
  */
-class PaletteEditor : public SharedRom, public Editor {
+class PaletteEditor : public Editor {
  public:
-  PaletteEditor() {
+  explicit PaletteEditor(Rom* rom = nullptr) : rom_(rom) {
     type_ = EditorType::kPalette;
     custom_palette_.push_back(gfx::SnesColor(0x7FFF));
   }
@@ -106,6 +106,12 @@ class PaletteEditor : public SharedRom, public Editor {
 
   void DrawModifiedColors();
 
+  // Set the ROM pointer
+  void set_rom(Rom* rom) { rom_ = rom; }
+  
+  // Get the ROM pointer
+  Rom* rom() const { return rom_; }
+
  private:
   absl::Status HandleColorPopup(gfx::SnesPalette& palette, int i, int j, int n);
 
@@ -119,6 +125,8 @@ class PaletteEditor : public SharedRom, public Editor {
   ImVec4 saved_palette_[256] = {};
 
   palette_internal::PaletteEditorHistory history_;
+
+  Rom* rom_;
 };
 
 }  // namespace editor

src/app/editor/graphics/screen_editor.h

@@ -28,12 +28,10 @@ namespace editor {
  *
  * The screens that can be edited include the title screen, naming screen,
  * overworld map, inventory menu, and more.
- *
- * The class inherits from the SharedRom class.
  */
-class ScreenEditor : public SharedRom, public Editor {
+class ScreenEditor : public Editor {
  public:
-  ScreenEditor() {
+  explicit ScreenEditor(Rom* rom = nullptr) : rom_(rom) {
     screen_canvas_.SetCanvasSize(ImVec2(512, 512));
     type_ = EditorType::kScreen;
   }
@@ -48,10 +46,17 @@ class ScreenEditor : public SharedRom, public Editor {
   absl::Status Paste() override { return absl::UnimplementedError("Paste"); }
   absl::Status Find() override { return absl::UnimplementedError("Find"); }
   absl::Status Save() override { return absl::UnimplementedError("Save"); }
+  
+  // Set the ROM pointer
+  void set_rom(Rom* rom) { rom_ = rom; }
+  
+  // Get the ROM pointer
+  Rom* rom() const { return rom_; }
 
   absl::Status SaveDungeonMaps();
 
  private:
+  Rom* rom_;
   void DrawTitleScreenEditor();
   void DrawNamingScreenEditor();
   void DrawOverworldMapEditor();