From d91f10e6eabdd568362395acf52cc419dcbd9045 Mon Sep 17 00:00:00 2001 From: scawful Date: Fri, 24 May 2024 21:30:07 -0400 Subject: [PATCH] add filename validation to rom load file --- src/app/rom.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/app/rom.cc b/src/app/rom.cc index ad2130dd..dd54ad9c 100644 --- a/src/app/rom.cc +++ b/src/app/rom.cc @@ -128,8 +128,12 @@ absl::Status Rom::LoadAllGraphicsData() { absl::Status Rom::LoadFromFile(const absl::string_view& filename, bool z3_load) { + if (filename.empty()) { + return absl::InvalidArgumentError( + "Could not load ROM: parameter `filename` is empty."); + } // Set filename - filename_ = filename; + filename_ = filename.data(); // Open file std::ifstream file(filename.data(), std::ios::binary);