From df695b8f86999ebe043fe5acb42a1497e77e51b4 Mon Sep 17 00:00:00 2001 From: scawful Date: Sat, 18 Oct 2025 12:09:21 -0400 Subject: [PATCH] chore: update CMake linking for test helpers to PRIVATE - Modified CMakeLists.txt for test helper executables to use PRIVATE visibility for linked libraries, ensuring encapsulation of dependencies. - This change enhances build clarity and prevents unintended linkage of libraries in other targets. Benefits: - Improves modularity and maintainability of the build configuration for test helpers. --- tools/test_helpers/CMakeLists.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/test_helpers/CMakeLists.txt b/tools/test_helpers/CMakeLists.txt index 3368bdaf..fea68157 100644 --- a/tools/test_helpers/CMakeLists.txt +++ b/tools/test_helpers/CMakeLists.txt @@ -3,7 +3,7 @@ add_executable(overworld_golden_data_extractor overworld_golden_data_extractor.cc ) -target_link_libraries(overworld_golden_data_extractor +target_link_libraries(overworld_golden_data_extractor PRIVATE yaze_core ${CMAKE_THREAD_LIBS_INIT} ) @@ -13,7 +13,7 @@ add_executable(extract_vanilla_values extract_vanilla_values.cc ) -target_link_libraries(extract_vanilla_values +target_link_libraries(extract_vanilla_values PRIVATE yaze_core ${CMAKE_THREAD_LIBS_INIT} ) @@ -23,7 +23,7 @@ add_executable(rom_patch_utility rom_patch_utility.cc ) -target_link_libraries(rom_patch_utility +target_link_libraries(rom_patch_utility PRIVATE yaze_core ${CMAKE_THREAD_LIBS_INIT} ) @@ -33,7 +33,7 @@ add_executable(dungeon_test_harness dungeon_test_harness.cc ) -target_link_libraries(dungeon_test_harness +target_link_libraries(dungeon_test_harness PRIVATE yaze_core ${CMAKE_THREAD_LIBS_INIT} )