scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(overworld): stabilize palette and tilemap saves

Browse Source
This commit is contained in:
scawful
2025-12-22 14:29:43 -05:00
parent ffc3ddd854
commit e733bc78d6
5 changed files with 102 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/e2e/rom_dependent/rom_version_test.cc
View File

@@ -28,6 +28,16 @@ namespace test {
*/
class RomVersionTest : public MultiVersionEditorSaveTest {
protected:
static int FindPrimaryMapId(const zelda3::Overworld& overworld) {
for (int i = 0; i < static_cast<int>(overworld.overworld_maps().size());
i++) {
if (overworld.overworld_map(i)->parent() == i) {
return i;
}
}
return 0;
}
// Version-specific address constants
struct VersionAddresses {
uint32_t overworld_gfx_ptr1;
@@ -337,7 +347,8 @@ TEST_F(RomVersionTest, MultipleCycles_Stability) {
<< "Map count mismatch on cycle " << cycle;
// Make a modification
auto* map = overworld.mutable_overworld_map(cycle % 160);
const int map_id = FindPrimaryMapId(overworld);
auto* map = overworld.mutable_overworld_map(map_id);
uint8_t new_value = static_cast<uint8_t>(cycle);
map->set_area_graphics(new_value);
@@ -353,7 +364,8 @@ TEST_F(RomVersionTest, MultipleCycles_Stability) {
ASSERT_OK(final_ow.Load(rom.get()));
// Verify last modification persisted
EXPECT_EQ(final_ow.overworld_map((num_cycles - 1) % 160)->area_graphics(),
const int map_id = FindPrimaryMapId(final_ow);
EXPECT_EQ(final_ow.overworld_map(map_id)->area_graphics(),
static_cast<uint8_t>(num_cycles - 1));
}