scawful/yaze
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor CMake configuration and improve emulation timing calculations

Browse Source 
- Updated CMakeLists.txt to disable additional optional components (EMU and Z3ED) in minimal builds for better build management.
- Refactored emulation timing calculations in emu.cc to use consistent method naming conventions, enhancing code readability and maintainability.
This commit is contained in:
scawful
2025-09-26 11:33:15 -04:00
parent 7c90b2b6ba
commit f0fa93fa2b
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CMakeLists.txt
View File

@@ -32,9 +32,11 @@ option(YAZE_ENABLE_EXPERIMENTAL_TESTS "Enable experimental/unstable tests" ON)
option(YAZE_ENABLE_UI_TESTS "Enable ImGui Test Engine UI testing" ON) option(YAZE_ENABLE_UI_TESTS "Enable ImGui Test Engine UI testing" ON)
option(YAZE_MINIMAL_BUILD "Minimal build for CI (disable optional features)" OFF) option(YAZE_MINIMAL_BUILD "Minimal build for CI (disable optional features)" OFF)
# Disable UI tests in minimal builds # Disable optional components in minimal builds
if(YAZE_MINIMAL_BUILD) if(YAZE_MINIMAL_BUILD)
set(YAZE_ENABLE_UI_TESTS OFF CACHE BOOL "Disabled for minimal build" FORCE) set(YAZE_ENABLE_UI_TESTS OFF CACHE BOOL "Disabled for minimal build" FORCE)
set(YAZE_BUILD_EMU OFF CACHE BOOL "Disabled for minimal build" FORCE)
set(YAZE_BUILD_Z3ED OFF CACHE BOOL "Disabled for minimal build" FORCE)
endif() endif()
set(YAZE_TEST_ROM_PATH "${CMAKE_BINARY_DIR}/bin/zelda3.sfc" CACHE STRING "Path to test ROM file") set(YAZE_TEST_ROM_PATH "${CMAKE_BINARY_DIR}/bin/zelda3.sfc" CACHE STRING "Path to test ROM file")

8
src/app/emu/emu.cc
View File

@@ -107,8 +107,8 @@ int main(int argc, char **argv) {
if (rom_.is_loaded()) { if (rom_.is_loaded()) {
rom_data_ = rom_.vector(); rom_data_ = rom_.vector();
snes_.Init(rom_data_); snes_.Init(rom_data_);
wanted_frames_ = 1.0 / (snes_.Memory().pal_timing() ? 50.0 : 60.0); wanted_frames_ = 1.0 / (snes_.memory().pal_timing() ? 50.0 : 60.0);
wanted_samples_ = 48000 / (snes_.Memory().pal_timing() ? 50 : 60); wanted_samples_ = 48000 / (snes_.memory().pal_timing() ? 50 : 60);
loaded = true; loaded = true;
} }
@@ -120,8 +120,8 @@ int main(int argc, char **argv) {
if (rom_.is_loaded()) { if (rom_.is_loaded()) {
rom_data_ = rom_.vector(); rom_data_ = rom_.vector();
snes_.Init(rom_data_); snes_.Init(rom_data_);
wanted_frames_ = 1.0 / (snes_.Memory().pal_timing() ? 50.0 : 60.0); wanted_frames_ = 1.0 / (snes_.memory().pal_timing() ? 50.0 : 60.0);
wanted_samples_ = 48000 / (snes_.Memory().pal_timing() ? 50 : 60); wanted_samples_ = 48000 / (snes_.memory().pal_timing() ? 50 : 60);
loaded = true; loaded = true;
} }
SDL_free(event.drop.file); SDL_free(event.drop.file);