Refactor ROM handling and remove SharedRom singleton for improved architecture

- Eliminated the SharedRom class to enhance modularity and reduce global state management.
- Updated various classes to directly manage ROM instances, improving clarity and encapsulation.
- Added new functions for loading messages and colors from ROM, enhancing functionality.
- Refactored Canvas and Editor classes to utilize direct ROM references, streamlining interactions.
- Improved documentation and comments for better code understanding and maintainability.

src/app/editor/graphics/gfx_group_editor.h

@@ -13,7 +13,7 @@ namespace editor {
  * @class GfxGroupEditor
  * @brief Manage graphics group configurations in a Rom.
  */
-class GfxGroupEditor : public SharedRom {
+class GfxGroupEditor {
  public:
   absl::Status Update();
 
@@ -27,6 +27,8 @@ class GfxGroupEditor : public SharedRom {
   void SetSelectedSpriteset(uint8_t spriteset) {
     selected_spriteset_ = spriteset;
   }
+  void set_rom(Rom* rom) { rom_ = rom; }
+  Rom* rom() const { return rom_; }
 
  private:
   uint8_t selected_blockset_ = 0;
@@ -39,6 +41,7 @@ class GfxGroupEditor : public SharedRom {
   gui::Canvas spriteset_canvas_;
 
   gfx::SnesPalette palette_;
+  Rom* rom_ = nullptr;
 };
 
 }  // namespace editor

src/app/editor/overworld/overworld_editor.cc

@@ -586,7 +586,9 @@ absl::Status OverworldEditor::CheckForCurrentMap() {
   }
   const int current_highlighted_map = current_map_;
 
-  current_parent_ = overworld_.overworld_map(current_map_)->parent();
+  if (!current_map_lock_) {
+    current_parent_ = overworld_.overworld_map(current_map_)->parent();
+  }
 
   if (overworld_.overworld_map(current_map_)->is_large_map() ||
       overworld_.overworld_map(current_map_)->large_index() != 0) {
@@ -613,6 +615,11 @@ absl::Status OverworldEditor::CheckForCurrentMap() {
     maps_bmp_[current_map_].set_modified(false);
   }
 
+  // If double clicked, toggle the current map
+  if (ImGui::IsMouseDoubleClicked(ImGuiMouseButton_Right)) {
+    current_map_lock_ = !current_map_lock_;
+  }
+
   return absl::OkStatus();
 }
 

src/app/editor/overworld/overworld_editor.h

@@ -31,7 +31,8 @@ constexpr ImVec2 kBlocksetCanvasSize(0x100 + 1, 0x4000 + 1);
 constexpr ImVec2 kGraphicsBinCanvasSize(0x100 + 1, kNumSheetsToLoad * 0x40 + 1);
 
 constexpr ImGuiTableFlags kOWMapFlags =
-    ImGuiTableFlags_Borders | ImGuiTableFlags_Resizable;
+    ImGuiTableFlags_Borders | ImGuiTableFlags_Resizable |
+    ImGuiTableFlags_RowBg | ImGuiTableFlags_SizingStretchProp;
 constexpr ImGuiTableFlags kToolsetTableFlags = ImGuiTableFlags_SizingFixedFit;
 constexpr ImGuiTableFlags kOWEditFlags =
     ImGuiTableFlags_Resizable | ImGuiTableFlags_Reorderable |
@@ -75,6 +76,7 @@ class OverworldEditor : public Editor, public gfx::GfxContext {
  public:
   explicit OverworldEditor(Rom* rom) : rom_(rom) {
     type_ = EditorType::kOverworld;
+    gfx_group_editor_.set_rom(rom);
   }
 
   void Initialize() override;
@@ -212,12 +214,13 @@ class OverworldEditor : public Editor, public gfx::GfxContext {
   bool overworld_canvas_fullscreen_ = false;
   bool middle_mouse_dragging_ = false;
   bool is_dragging_entity_ = false;
+  bool current_map_lock_ = false;
 
   gfx::Tilemap tile16_blockset_;
 
   Rom* rom_;
 
-  Tile16Editor tile16_editor_{&tile16_blockset_};
+  Tile16Editor tile16_editor_{rom_, &tile16_blockset_};
   GfxGroupEditor gfx_group_editor_;
   PaletteEditor palette_editor_;
 

src/app/editor/overworld/tile16_editor.cc

@@ -245,7 +245,7 @@ absl::Status Tile16Editor::DrawToCurrentTile16(ImVec2 click_position) {
 }
 
 absl::Status Tile16Editor::UpdateTile16Edit() {
-  auto ow_main_pal_group = rom()->palette_group().overworld_main;
+  static const auto ow_main_pal_group = rom()->palette_group().overworld_main;
 
   // Create a more organized layout with tabs
   if (BeginTabBar("Tile16EditorTabs")) {

src/app/editor/overworld/tile16_editor.h

@@ -22,9 +22,10 @@ namespace editor {
 /**
  * @brief Popup window to edit Tile16 data
  */
-class Tile16Editor : public gfx::GfxContext, public SharedRom {
+class Tile16Editor : public gfx::GfxContext {
  public:
-  Tile16Editor(gfx::Tilemap *tile16_blockset) : tile16_blockset_(tile16_blockset) {}
+  Tile16Editor(Rom *rom, gfx::Tilemap *tile16_blockset)
+      : rom_(rom), tile16_blockset_(tile16_blockset) {}
   absl::Status Initialize(const gfx::Bitmap &tile16_blockset_bmp,
                           const gfx::Bitmap &current_gfx_bmp,
                           std::array<uint8_t, 0x200> &all_tiles_types);
@@ -52,7 +53,11 @@ class Tile16Editor : public gfx::GfxContext, public SharedRom {
   absl::Status LoadTile16FromScratchSpace(int slot);
   absl::Status ClearScratchSpace(int slot);
 
+  void set_rom(Rom *rom) { rom_ = rom; }
+  Rom *rom() const { return rom_; }
+
  private:
+  Rom *rom_ = nullptr;
   bool map_blockset_loaded_ = false;
   bool transfer_started_ = false;
   bool transfer_blockset_loaded_ = false;