scawful/oracle-of-secrets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Time System BG color tinting and overlay clearing bugs

Browse Source 
- Fixed: BG color resetting to untinted value on screen transitions (InitColorLoad2).
- Fixed: Addressing mode error in ColorSubEffect causing incorrect tinting.
- Fixed: Active overlays being cleared when hour advances due to static table lookup and incomplete logic in Overworld_LoadBGColorAndSubscreenOverlay.
- Updated handoff documentation with resolution details.
This commit is contained in:
scawful
2025-11-22 16:41:58 -05:00
parent 8b23049e28
commit 2b504d987f
3 changed files with 150 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Overworld/time_system.asm
View File

@@ -387,22 +387,22 @@ ColorSubEffect:
AND #$00FF : TAX
; Subtract amount to blue field based on a table
LDA.l !SubPalColor : AND #$7C00 : STA !BlueVal
SEC : SBC.l .blue, X : STA !TempPalColor
LDA.l !SubPalColor : AND #$7C00 : STA.l !BlueVal
SEC : SBC.l .blue, X : STA.l !TempPalColor
; mask out everything except the blue bits
AND #$7C00 : CMP !TempPalColor : BEQ .no_blue_sign_change ; overflow ?
LDA !SmallestBlue
AND #$7C00 : CMP.l !TempPalColor : BEQ .no_blue_sign_change ; overflow ?
LDA.l !SmallestBlue
.no_blue_sign_change
STA.l !BlueVal
; Subtract amount to green field based on a table
LDA !SubPalColor : AND #$03E0 : STA !GreenVal
LDA.l !SubPalColor : AND #$03E0 : STA.l !GreenVal
SEC : SBC.l .green, X : STA.l !TempPalColor
; Mask out everything except the green bits
AND #$03E0 : CMP !TempPalColor : BEQ .no_green_sign_change ; overflow ?
LDA !SmallestGreen
AND #$03E0 : CMP.l !TempPalColor : BEQ .no_green_sign_change ; overflow ?
LDA.l !SmallestGreen
.no_green_sign_change
STA.l !GreenVal
@@ -411,8 +411,8 @@ ColorSubEffect:
SEC : SBC.l .red, X : STA.l !TempPalColor
; mask out everything except the red bits
AND #$001F : CMP !TempPalColor : BEQ .no_red_sign_change ; overflow ?
LDA !SmallestRed
AND #$001F : CMP.l !TempPalColor : BEQ .no_red_sign_change ; overflow ?
LDA.l !SmallestRed
.no_red_sign_change
STA.l !RedVal