add filename validation to rom load file

2024-05-24 21:30:07 -04:00
parent f28e26ef28
commit d91f10e6ea
1 changed files with 5 additions and 1 deletions
--- a/src/app/rom.cc
+++ b/src/app/rom.cc
@@ -128,8 +128,12 @@ absl::Status Rom::LoadAllGraphicsData() {

 absl::Status Rom::LoadFromFile(const absl::string_view& filename,
                               bool z3_load) {
+  if (filename.empty()) {
+    return absl::InvalidArgumentError(
+        "Could not load ROM: parameter `filename` is empty.");
+  }
  // Set filename
-  filename_ = filename;
+  filename_ = filename.data();

  // Open file
  std::ifstream file(filename.data(), std::ios::binary);